system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-06 08:54:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

winegcc: Prefer -Wl,--pdb=<file> over -Wl,-pdb,<file>.

Browse source 
The previously used syntax, -Wl,-pdb,<file>, was the originally
supported one in lld (since 2018). Later (in 2019) the second
syntax was added, allowing both -Wl,-pdb=<file> and -Wl,-pdb,<file>.
(This other parameter syntax allows easier distinguishing an empty
argument, for letting the linker implicitly pick the file name.)

Move over to using the more modern syntax - reducing the usage of
the old form of the option. This potentially allows deprecating
the original syntax and maybe allows using --pdb as a boolean
flag for implying an automatically named PDB file (which currently
requires using the awkward syntax "--pdb=").

Also prefer the long two dashes form, i.e. --pdb instead of -pdb;
the single dash form is only allowed by getopt when there
are no conflicts with single-letter options, while the form with
two dashes is unambiguous.
This commit is contained in:
Martin Storsjö 2022-10-20 23:52:13 +03:00 committed by Alexandre Julliard
parent 2d90027bef
commit 6705a71045
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/winegcc/winegcc.c
View file

@ -464,7 +464,7 @@ static struct strarray get_link_args( struct options *opts, const char *output_n
strarray_add( &flags, "-static-libgcc" );
if (opts->debug_file && strendswith(opts->debug_file, ".pdb"))
strarray_add(&link_args, strmake("-Wl,-pdb,%s", opts->debug_file));
strarray_add(&link_args, strmake("-Wl,--pdb=%s", opts->debug_file));
if (opts->out_implib)
strarray_add(&link_args, strmake("-Wl,--out-implib,%s", opts->out_implib));