system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-07-21 11:54:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mmdevapi: Warn if returned device name is too long.

Browse source 
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Gabriel Ivăncescu 2022-05-26 19:06:39 +03:00 committed by Alexandre Julliard
parent f5fc65ab86
commit 653d04d7f9
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
dlls/mmdevapi/devenum.c
View file

@ -1378,6 +1378,7 @@ static HRESULT WINAPI MMDevPropStore_GetAt(IPropertyStore *iface, DWORD prop, PR
static HRESULT WINAPI MMDevPropStore_GetValue(IPropertyStore *iface, REFPROPERTYKEY key, PROPVARIANT *pv)
{
MMDevPropStore *This = impl_from_IPropertyStore(iface);
HRESULT hres;
TRACE("(%p)->(\"%s,%lu\", %p)\n", This, key ? debugstr_guid(&key->fmtid) : NULL, key ? key->pid : 0, pv);
if (!key || !pv)
@ -1397,7 +1398,19 @@ static HRESULT WINAPI MMDevPropStore_GetValue(IPropertyStore *iface, REFPROPERTY
return S_OK;
}
return MMDevice_GetPropValue(&This->parent->devguid, This->parent->flow, key, pv);
hres = MMDevice_GetPropValue(&This->parent->devguid, This->parent->flow, key, pv);
if (FAILED(hres))
return hres;
if (WARN_ON(mmdevapi))
{
if ((IsEqualPropertyKey(*key, DEVPKEY_Device_FriendlyName) ||
IsEqualPropertyKey(*key, DEVPKEY_DeviceInterface_FriendlyName) ||
IsEqualPropertyKey(*key, DEVPKEY_Device_DeviceDesc)) &&
pv->vt == VT_LPWSTR && wcslen(pv->pwszVal) > 62)
WARN("Returned name exceeds length limit of some broken apps/libs, might crash: %s\n", debugstr_w(pv->pwszVal));
}
return hres;
}
static HRESULT WINAPI MMDevPropStore_SetValue(IPropertyStore *iface, REFPROPERTYKEY key, REFPROPVARIANT pv)