system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-19 20:48:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

wininet: Simplify the check for an empty string (PVS-Studio).

Browse source
This commit is contained in:
Michael Stefaniuc 2014-11-10 23:41:51 +01:00 committed by Alexandre Julliard
parent b91084a992
commit 51302e011a
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dlls/wininet/ftp.c
View file

@ -2496,7 +2496,7 @@ HINTERNET FTP_Connect(appinfo_t *hIC, LPCWSTR lpszServerName,
if(hIC->proxyBypass) if(hIC->proxyBypass)
FIXME("Proxy bypass is ignored.\n"); FIXME("Proxy bypass is ignored.\n");
} }
if (!lpszUserName || !strlenW(lpszUserName)) { if (!lpszUserName || !lpszUserName[0]) {
HKEY key; HKEY key;
WCHAR szPassword[MAX_PATH]; WCHAR szPassword[MAX_PATH];
DWORD len = sizeof(szPassword); DWORD len = sizeof(szPassword);

8
dlls/wininet/tests/internet.c
View file

@ -1578,7 +1578,7 @@ static void test_InternetGetConnectedStateExA(void)
res = pInternetGetConnectedStateExA(&flags, buffer, 1, 0); res = pInternetGetConnectedStateExA(&flags, buffer, 1, 0);
ok(res == TRUE, "Expected TRUE, got %d\n", res); ok(res == TRUE, "Expected TRUE, got %d\n", res);
ok(flags, "Expected at least one flag set\n"); ok(flags, "Expected at least one flag set\n");
ok(strlen(buffer) == 0, "Expected 0 bytes, got %u\n", lstrlenA(buffer)); ok(!buffer[0], "Expected 0 bytes, got %u\n", lstrlenA(buffer));
buffer[0] = 0; buffer[0] = 0;
flags = 0; flags = 0;
@ -1592,7 +1592,7 @@ static void test_InternetGetConnectedStateExA(void)
res = pInternetGetConnectedStateExA(&flags, buffer, 1, 0); res = pInternetGetConnectedStateExA(&flags, buffer, 1, 0);
ok(res == TRUE, "Expected TRUE, got %d\n", res); ok(res == TRUE, "Expected TRUE, got %d\n", res);
ok(flags, "Expected at least one flag set\n"); ok(flags, "Expected at least one flag set\n");
ok(strlen(buffer) == 0, "Expected 0 bytes, got %u\n", lstrlenA(buffer)); ok(!buffer[0], "Expected 0 bytes, got %u\n", lstrlenA(buffer));
} }
static void test_InternetGetConnectedStateExW(void) static void test_InternetGetConnectedStateExW(void)
@ -1667,7 +1667,7 @@ static void test_InternetGetConnectedStateExW(void)
res = pInternetGetConnectedStateExW(&flags, buffer, 1, 0); res = pInternetGetConnectedStateExW(&flags, buffer, 1, 0);
ok(res == TRUE, "Expected TRUE, got %d\n", res); ok(res == TRUE, "Expected TRUE, got %d\n", res);
ok(flags, "Expected at least one flag set\n"); ok(flags, "Expected at least one flag set\n");
ok(lstrlenW(buffer) == 0, "Expected 0 bytes, got %u\n", lstrlenW(buffer)); ok(!buffer[0], "Expected 0 bytes, got %u\n", lstrlenW(buffer));
buffer[0] = 0; buffer[0] = 0;
flags = 0; flags = 0;
@ -1681,7 +1681,7 @@ static void test_InternetGetConnectedStateExW(void)
res = pInternetGetConnectedStateExW(&flags, buffer, 1, 0); res = pInternetGetConnectedStateExW(&flags, buffer, 1, 0);
ok(res == TRUE, "Expected TRUE, got %d\n", res); ok(res == TRUE, "Expected TRUE, got %d\n", res);
ok(flags, "Expected at least one flag set\n"); ok(flags, "Expected at least one flag set\n");
ok(lstrlenW(buffer) == 0, "Expected 0 bytes, got %u\n", lstrlenW(buffer)); ok(!buffer[0], "Expected 0 bytes, got %u\n", lstrlenW(buffer));
} }
/* ############################### */ /* ############################### */