system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-01 18:53:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

qedit/tests: Fix a file handle leak on error path (Coverity).

Browse source
This commit is contained in:
Nikolay Sivov 2014-04-10 09:18:17 +04:00 committed by Alexandre Julliard
parent ed51082dd6
commit 4f681295d6
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
dlls/qedit/tests/mediadet.c
View file

@ -84,6 +84,7 @@ static BOOL unpack_avi_file(int id, WCHAR name[MAX_PATH])
char *mem;
DWORD size, written;
HANDLE fh;
BOOL ret;
res = FindResourceW(NULL, MAKEINTRESOURCEW(id), MAKEINTRESOURCEW(AVI_RES_TYPE));
if (!res)
@ -116,12 +117,9 @@ static BOOL unpack_avi_file(int id, WCHAR name[MAX_PATH])
if (fh == INVALID_HANDLE_VALUE)
return FALSE;
if (!WriteFile(fh, mem, size, &written, NULL) || written != size)
return FALSE;
ret = WriteFile(fh, mem, size, &written, NULL);
CloseHandle(fh);
return TRUE;
return ret && written == size;
}
static BOOL init_tests(void)