system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-15 06:10:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

winspool: Declare JobW as a void pointer in SetJobA.

Browse source 
To reduce the number of casts required and avoid a scan-build warning.
This commit is contained in:
Alex Henrie 2023-07-02 17:20:08 -06:00 committed by Alexandre Julliard
parent 044fbbd5a3
commit 45f9ab9286
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
dlls/winspool.drv/info.c
View file

@ -2979,7 +2979,7 @@ BOOL WINAPI SetJobA(HANDLE hPrinter, DWORD JobId, DWORD Level,
LPBYTE pJob, DWORD Command)
{
BOOL ret;
LPBYTE JobW;
void *JobW;
UNICODE_STRING usBuffer;
TRACE("(%p, %ld, %ld, %p, %ld)\n",hPrinter, JobId, Level, pJob, Command);
@ -2996,7 +2996,7 @@ BOOL WINAPI SetJobA(HANDLE hPrinter, DWORD JobId, DWORD Level,
JOB_INFO_1W *info1W = malloc(sizeof(*info1W));
JOB_INFO_1A *info1A = (JOB_INFO_1A*)pJob;
JobW = (LPBYTE)info1W;
JobW = info1W;
info1W->pUserName = asciitounicode(&usBuffer, info1A->pUserName);
info1W->pDocument = asciitounicode(&usBuffer, info1A->pDocument);
info1W->pDatatype = asciitounicode(&usBuffer, info1A->pDatatype);
@ -3012,7 +3012,7 @@ BOOL WINAPI SetJobA(HANDLE hPrinter, DWORD JobId, DWORD Level,
JOB_INFO_2W *info2W = malloc(sizeof(*info2W));
JOB_INFO_2A *info2A = (JOB_INFO_2A*)pJob;
JobW = (LPBYTE)info2W;
JobW = info2W;
info2W->pUserName = asciitounicode(&usBuffer, info2A->pUserName);
info2W->pDocument = asciitounicode(&usBuffer, info2A->pDocument);
info2W->pNotifyName = asciitounicode(&usBuffer, info2A->pNotifyName);
@ -3045,7 +3045,7 @@ BOOL WINAPI SetJobA(HANDLE hPrinter, DWORD JobId, DWORD Level,
{
case 1:
{
JOB_INFO_1W *info1W = (JOB_INFO_1W*)JobW;
JOB_INFO_1W *info1W = JobW;
free(info1W->pUserName);
free(info1W->pDocument);
free(info1W->pDatatype);
@ -3054,7 +3054,7 @@ BOOL WINAPI SetJobA(HANDLE hPrinter, DWORD JobId, DWORD Level,
}
case 2:
{
JOB_INFO_2W *info2W = (JOB_INFO_2W*)JobW;
JOB_INFO_2W *info2W = JobW;
free(info2W->pUserName);
free(info2W->pDocument);
free(info2W->pNotifyName);