From 3d383c468b1b6e784dee13e4b55a0972c79f83f2 Mon Sep 17 00:00:00 2001 From: Alex Henrie Date: Sun, 18 Jun 2023 22:32:00 -0600 Subject: [PATCH] regedit: Fix memory leak on error path in RenameKey (scan-build). parentPath is allocated before parentKey. --- programs/regedit/edit.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/programs/regedit/edit.c b/programs/regedit/edit.c index 66d3a27dc68..947a6071e0f 100644 --- a/programs/regedit/edit.c +++ b/programs/regedit/edit.c @@ -680,9 +680,7 @@ BOOL RenameKey(HWND hwnd, HKEY hRootKey, LPCWSTR keyPath, LPCWSTR newName) done: RegCloseKey(destKey); - if (parentKey) { - RegCloseKey(parentKey); - free(parentPath); - } + RegCloseKey(parentKey); + free(parentPath); return result; }