system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-31 12:19:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

winhelp: Avoid accessing a window in global window list after it has been freed.

Browse source
This commit is contained in:
Eric Pouech 2010-06-12 21:55:05 +02:00 committed by Alexandre Julliard
parent 2d20a1aa53
commit 3b07c851f8
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
programs/winhlp32/macro.c
View file

@ -281,24 +281,32 @@ static void CALLBACK MACRO_CheckItem(LPCSTR str)
static void CALLBACK MACRO_CloseSecondarys(void)
{
WINHELP_WINDOW *win;
WINHELP_WINDOW *next;
WINE_TRACE("()\n");
for (win = Globals.win_list; win; win = win->next)
for (win = Globals.win_list; win; win = next)
{
next = win->next;
if (lstrcmpi(win->info->name, "main"))
WINHELP_ReleaseWindow(win);
}
}
static void CALLBACK MACRO_CloseWindow(LPCSTR lpszWindow)
{
WINHELP_WINDOW *win;
WINHELP_WINDOW *next;
WINE_TRACE("(\"%s\")\n", lpszWindow);
if (!lpszWindow || !lpszWindow[0]) lpszWindow = "main";
for (win = Globals.win_list; win; win = win->next)
for (win = Globals.win_list; win; win = next)
{
next = win->next;
if (!lstrcmpi(win->info->name, lpszWindow))
WINHELP_ReleaseWindow(win);
}
}
static void CALLBACK MACRO_Compare(LPCSTR str)