From 386dbe1059ba08485696760c267ef06dbed95bad Mon Sep 17 00:00:00 2001 From: David Kahurani Date: Thu, 18 Jan 2024 12:26:14 +0300 Subject: [PATCH] msi: Avoid leaking stream on DB update. MSI_RecordGetIStream adds a reference to the stream. This reference should be negated as we are done setting the stream. Signed-off-by: David Kahurani --- dlls/msi/select.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/msi/select.c b/dlls/msi/select.c index cfb17f60b62..975d2b8e066 100644 --- a/dlls/msi/select.c +++ b/dlls/msi/select.c @@ -20,6 +20,8 @@ #include +#define COBJMACROS + #include "windef.h" #include "winbase.h" #include "winerror.h" @@ -269,6 +271,7 @@ UINT msi_select_update(MSIVIEW *view, MSIRECORD *rec, UINT row) if (MSI_RecordGetIStream(rec, i + 1, &stream)) return ERROR_FUNCTION_FAILED; r = sv->table->ops->set_stream(sv->table, row, col, stream); + IStream_Release(stream); } else if (type & MSITYPE_STRING) {