system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-14 19:15:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

wined3d: Do not track dirty ranges for buffers without WINED3D_BUFFER_USE_BO.

Browse source 
Since we never upload the buffer, and may very well never invalidate the whole
thing, this just results in continually increasing memory consumption.

This is especially a problem for our internal push constant buffers, which are
sysmem buffers that usually are never wholly invalidated, but it could also
potentially be a problem for other buffers.
This commit is contained in:
Zebediah Figura 2023-10-14 12:57:11 -05:00 committed by Alexandre Julliard
parent 8378a786a6
commit 307b200363
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dlls/wined3d/buffer.c
View file

@ -122,7 +122,7 @@ static void wined3d_buffer_invalidate_range(struct wined3d_buffer *buffer, DWORD
TRACE("buffer %p, location %s, offset %u, size %u.\n",
buffer, wined3d_debug_location(location), offset, size);
if (location & WINED3D_LOCATION_BUFFER)
if ((location & WINED3D_LOCATION_BUFFER) && (buffer->flags & WINED3D_BUFFER_USE_BO))
buffer_invalidate_bo_range(buffer, offset, size);
buffer->locations &= ~location;
@ -1399,7 +1399,7 @@ static HRESULT wined3d_buffer_init(struct wined3d_buffer *buffer, struct wined3d
return E_OUTOFMEMORY;
}
if (!wined3d_array_reserve((void **)&buffer->dirty_ranges,
if ((buffer->flags & WINED3D_BUFFER_USE_BO) && !wined3d_array_reserve((void **)&buffer->dirty_ranges,
&buffer->dirty_ranges_capacity, 1, sizeof(*buffer->dirty_ranges)))
{
ERR("Out of memory.\n");