system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-07-21 19:04:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dmband: Avoid cloning stream in parse_bands_list.

Browse source 
A stream that doesn't implement ::Clone can be passed, causing IStream_Seek to crash.

Signed-off-by: Myah Caron <qsniyg@protonmail.com>
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Myah Caron 2020-09-17 05:18:08 -07:00 committed by Alexandre Julliard
parent d28c7938c7
commit 2cf69bb5a5
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
dlls/dmband/bandtrack.c
View file

@ -425,21 +425,22 @@ static HRESULT parse_bands_list(IDirectMusicBandTrack *This, DMUS_PRIVATE_CHUNK
StreamSize = Chunk.dwSize - sizeof(FOURCC);
switch (Chunk.fccID) {
case DMUS_FOURCC_BAND_FORM: {
LPSTREAM pClonedStream = NULL;
ULARGE_INTEGER liOrigPos;
TRACE_(dmfile)(": BAND RIFF\n");
IStream_Clone (pStm, &pClonedStream);
liMove.QuadPart = 0;
liMove.QuadPart -= sizeof(FOURCC) + (sizeof(FOURCC)+sizeof(DWORD));
IStream_Seek (pClonedStream, liMove, STREAM_SEEK_CUR, NULL);
hr = load_band(This, pClonedStream, &pBand, &header);
liMove.QuadPart = 0;
IStream_Seek (pStm, liMove, STREAM_SEEK_CUR, &liOrigPos);
liMove.QuadPart -= sizeof(FOURCC) + (sizeof(FOURCC)+sizeof(DWORD));
IStream_Seek (pStm, liMove, STREAM_SEEK_CUR, NULL);
hr = load_band(This, pStm, &pBand, &header);
if (FAILED(hr)) {
ERR(": could not load track\n");
return hr;
}
IStream_Release (pClonedStream);
liMove.QuadPart = (LONGLONG)liOrigPos.QuadPart;
IStream_Seek (pStm, liMove, STREAM_SEEK_SET, NULL);
IDirectMusicTrack_Release(pBand); pBand = NULL; /* now we can release at as it inserted */