system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-07-24 11:59:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mshtml: Traverse and unlink the Element referenced from the CurrentStyle.

Browse source 
This was actually leaking even before the Cycle Collection was implemented.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
This commit is contained in:
Gabriel Ivăncescu 2023-11-02 16:11:20 +02:00 committed by Alexandre Julliard
parent db2d10b3a3
commit 213786efe2
1 changed files with 29 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
dlls/mshtml/htmlcurstyle.c
View file

@ -1278,9 +1278,14 @@ static const IHTMLCurrentStyle4Vtbl HTMLCurrentStyle4Vtbl = {
HTMLCurrentStyle4_get_maxWidth
};
static inline HTMLCurrentStyle *impl_from_DispatchEx(DispatchEx *dispex)
{
return CONTAINING_RECORD(dispex, HTMLCurrentStyle, css_style.dispex);
}
static void *HTMLCurrentStyle_query_interface(DispatchEx *dispex, REFIID riid)
{
HTMLCurrentStyle *This = CONTAINING_RECORD(dispex, HTMLCurrentStyle, css_style.dispex);
HTMLCurrentStyle *This = impl_from_DispatchEx(dispex);
if(IsEqualGUID(&IID_IHTMLCurrentStyle, riid))
return &This->IHTMLCurrentStyle_iface;
@ -1293,11 +1298,32 @@ static void *HTMLCurrentStyle_query_interface(DispatchEx *dispex, REFIID riid)
return CSSStyle_query_interface(&This->css_style.dispex, riid);
}
static void HTMLCurrentStyle_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb)
{
HTMLCurrentStyle *This = impl_from_DispatchEx(dispex);
CSSStyle_traverse(&This->css_style.dispex, cb);
if(This->elem)
note_cc_edge((nsISupports*)&This->elem->node.IHTMLDOMNode_iface, "elem", cb);
}
static void HTMLCurrentStyle_unlink(DispatchEx *dispex)
{
HTMLCurrentStyle *This = impl_from_DispatchEx(dispex);
CSSStyle_unlink(&This->css_style.dispex);
if(This->elem) {
HTMLElement *elem = This->elem;
This->elem = NULL;
IHTMLDOMNode_Release(&elem->node.IHTMLDOMNode_iface);
}
}
static const dispex_static_data_vtbl_t HTMLCurrentStyle_dispex_vtbl = {
CSSSTYLE_DISPEX_VTBL_ENTRIES,
.query_interface = HTMLCurrentStyle_query_interface,
.traverse = CSSStyle_traverse,
.unlink = CSSStyle_unlink
.traverse = HTMLCurrentStyle_traverse,
.unlink = HTMLCurrentStyle_unlink
};
static const tid_t HTMLCurrentStyle_iface_tids[] = {