system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-15 01:34:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

kernel32/tests: Fix sporadic process test failure.

Browse source 
Current test tries to ensure that a handle, valid in process parent,
hasn't been inherited, but nothing guarantees that a valid handle
isn't present in child process with same value.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
This commit is contained in:
Eric Pouech 2022-11-04 15:41:49 +01:00 committed by Alexandre Julliard
parent 8f1febc430
commit 1addbe3e1d
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
dlls/kernel32/tests/process.c
View file

@ -4280,16 +4280,26 @@ static void test_handle_list_attribute(BOOL child, HANDLE handle1, HANDLE handle
if (child)
{
char name1[256], name2[256];
DWORD flags;
flags = 0;
ret = GetHandleInformation(handle1, &flags);
ok(ret, "Failed to get handle info, error %ld.\n", GetLastError());
ok(flags == HANDLE_FLAG_INHERIT, "Unexpected flags %#lx.\n", flags);
ret = GetFileInformationByHandleEx(handle1, FileNameInfo, name1, sizeof(name1));
ok(ret, "Failed to get pipe name, error %ld\n", GetLastError());
CloseHandle(handle1);
flags = 0;
ret = GetHandleInformation(handle2, &flags);
ok(!ret && GetLastError() == ERROR_INVALID_HANDLE, "Unexpected return value, error %ld.\n", GetLastError());
if (ret)
{
ok(!(flags & HANDLE_FLAG_INHERIT), "Parent's handle shouldn't have been inherited\n");
ret = GetFileInformationByHandleEx(handle2, FileNameInfo, name2, sizeof(name2));
ok(!ret || strcmp(name1, name2), "Parent's handle shouldn't have been inherited\n");
}
else
ok(GetLastError() == ERROR_INVALID_HANDLE, "Unexpected return value, error %ld.\n", GetLastError());
return;
}