system/wine
system/wine
1
0
Fork 0
mirror of https://github.com/wine-mirror/wine synced 2024-07-09 04:16:08 +00:00
Code Issues Projects Releases Wiki Activity

dinput/tests: Remove racy IForceFeedbackEffect reference count checks.

Browse Source 
Because the async operation holds a reference on the invoker and the
param, it may keep the effect alive until the worker thread releases
its reference on the async operation. We have no way to synchronize on
that.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53199
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
This commit is contained in:
Rémi Bernon 2022-07-07 08:52:07 +02:00 committed by Alexandre Julliard
parent 2020541b4b
commit 1854001c79
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
dlls/dinput/tests/force_feedback.c
View File

@ -5673,7 +5673,6 @@ static void test_windows_gaming_input(void)
UINT32 size;
HRESULT hr;
DWORD ret;
LONG ref;
if (!load_combase_functions()) return;
@ -6053,8 +6052,7 @@ static void test_windows_gaming_input(void)
todo_wine
ok( hr == 0x86854003, "TryUnloadEffectAsync returned %#lx\n", hr );
ref = IForceFeedbackEffect_Release( effect );
ok( ref == 0, "Release returned %lu\n", ref );
IForceFeedbackEffect_Release( effect );
hr = IPeriodicForceEffectFactory_CreateInstance( periodic_factory, PeriodicForceEffectKind_SineWave, &effect );
@ -6127,8 +6125,7 @@ static void test_windows_gaming_input(void)
IAsyncOperation_boolean_Release( bool_async );
set_hid_expect( file, NULL, 0 );
ref = IForceFeedbackEffect_Release( effect );
ok( ref == 0, "Release returned %lu\n", ref );
IForceFeedbackEffect_Release( effect );
IPeriodicForceEffectFactory_Release( periodic_factory );
@ -6220,8 +6217,7 @@ static void test_windows_gaming_input(void)
IAsyncOperation_boolean_Release( bool_async );
set_hid_expect( file, NULL, 0 );
ref = IForceFeedbackEffect_Release( effect );
ok( ref == 0, "Release returned %lu\n", ref );
IForceFeedbackEffect_Release( effect );
IConditionForceEffectFactory_Release( condition_factory );
@ -6313,8 +6309,7 @@ static void test_windows_gaming_input(void)
IAsyncOperation_boolean_Release( bool_async );
set_hid_expect( file, NULL, 0 );
ref = IForceFeedbackEffect_Release( effect );
ok( ref == 0, "Release returned %lu\n", ref );
IForceFeedbackEffect_Release( effect );
hr = pWindowsCreateString( ramp_effect_class_name, wcslen( ramp_effect_class_name ), &str );
@ -6387,8 +6382,7 @@ static void test_windows_gaming_input(void)
IAsyncOperation_boolean_Release( bool_async );
set_hid_expect( file, NULL, 0 );
ref = IForceFeedbackEffect_Release( effect );
ok( ref == 0, "Release returned %lu\n", ref );
IForceFeedbackEffect_Release( effect );
IForceFeedbackMotor_Release( motor );