system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-06 09:35:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

uxtheme: Reference count theme classes.

Browse source 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=29974
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
This commit is contained in:
Zhiyi Zhang 2022-08-12 11:32:54 +08:00 committed by Alexandre Julliard
parent 2ae7ecb936
commit 113eca095a
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
dlls/uxtheme/msstyles.c
View file

@ -447,6 +447,7 @@ static PTHEME_CLASS MSSTYLES_AddClass(PTHEME_FILE tf, LPCWSTR pszAppName, LPCWST
cur = heap_alloc(sizeof(*cur));
cur->signature = THEME_CLASS_SIGNATURE;
cur->refcount = 0;
cur->hTheme = tf->hTheme;
lstrcpyW(cur->szAppName, pszAppName);
lstrcpyW(cur->szClassName, pszClassName);
@ -1061,6 +1062,7 @@ PTHEME_CLASS MSSTYLES_OpenThemeClass(LPCWSTR pszAppName, LPCWSTR pszClassList, U
TRACE("Opened app %s, class %s from list %s\n", debugstr_w(cls->szAppName), debugstr_w(cls->szClassName), debugstr_w(pszClassList));
cls->tf = tfActiveTheme;
cls->tf->dwRefCount++;
InterlockedIncrement(&cls->refcount);
cls->dpi = dpi;
}
return cls;
@ -1080,6 +1082,8 @@ PTHEME_CLASS MSSTYLES_OpenThemeClass(LPCWSTR pszAppName, LPCWSTR pszClassList, U
*/
HRESULT MSSTYLES_CloseThemeClass(PTHEME_CLASS tc)
{
LONG refcount;
__TRY
{
if (tc->signature != THEME_CLASS_SIGNATURE)
@ -1097,7 +1101,10 @@ HRESULT MSSTYLES_CloseThemeClass(PTHEME_CLASS tc)
return E_HANDLE;
}
MSSTYLES_CloseThemeFile (tc->tf);
refcount = InterlockedDecrement(&tc->refcount);
/* Some buggy apps may double free HTHEME handles */
if (refcount >= 0)
MSSTYLES_CloseThemeFile(tc->tf);
return S_OK;
}

1
dlls/uxtheme/msstyles.h
View file

@ -50,6 +50,7 @@ struct _THEME_FILE;
typedef struct _THEME_CLASS {
DWORD signature;
LONG refcount;
HMODULE hTheme;
struct _THEME_FILE* tf;
WCHAR szAppName[MAX_THEME_APP_NAME];