system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-01 00:43:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

shell32: Handle memory allocation failure in parse_dde_command (cppcheck).

Browse source
This commit is contained in:
Alex Henrie 2022-12-11 21:40:17 -07:00 committed by Alexandre Julliard
parent 7ebb621e83
commit 0f6dcbbb2c
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
dlls/shell32/dde.c
View file

@ -347,7 +347,7 @@ static DWORD PROGMAN_OnExecute(WCHAR *command, int argc, WCHAR **argv)
static DWORD parse_dde_command(HSZ hszTopic, WCHAR *command)
{
WCHAR *original = command;
WCHAR *opcode = NULL, **argv = NULL, *p;
WCHAR *opcode = NULL, **argv = NULL, **new_argv, *p;
int argc = 0, i;
DWORD ret = DDE_FACK;
@ -357,7 +357,7 @@ static DWORD parse_dde_command(HSZ hszTopic, WCHAR *command)
while (*command == '[')
{
argc = 0;
argv = malloc(sizeof(*argv));
argv = NULL;
command++;
while (*command == ' ') command++;
@ -385,9 +385,11 @@ static DWORD parse_dde_command(HSZ hszTopic, WCHAR *command)
while (p[-1] == ' ') p--;
}
new_argv = realloc(argv, (argc + 1) * sizeof(*argv));
if (!new_argv) goto error;
argv = new_argv;
argv[argc] = strndupW(command, p - command);
argc++;
argv = realloc(argv, argc * sizeof(*argv));
argv[argc-1] = strndupW(command, p - command);
command = p;
if (*command == '"') command++;