system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-06 08:54:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

msi: Fix double free on error paths in TransformView_Create (scan-build).

Browse source 
If TransformView_Create returns an error, it should not return a pointer
that table_load_transform will try to free.
This commit is contained in:
Alex Henrie 2023-06-11 21:59:26 -06:00 committed by Alexandre Julliard
parent 4db2ffa60e
commit 0653409e06
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
dlls/msi/table.c
View file

@ -2779,7 +2779,7 @@ static UINT TransformView_Create( MSIDATABASE *db, string_table *st, LPCWSTR nam
name_len = wcslen( name );
r = TABLE_CreateView( db, name, view );
r = TABLE_CreateView( db, name, (MSIVIEW **)&tv );
if (r == ERROR_INVALID_PARAMETER)
{
/* table does not exist */
@ -2790,16 +2790,11 @@ static UINT TransformView_Create( MSIDATABASE *db, string_table *st, LPCWSTR nam
tv->db = db;
memcpy( tv->name, name, name_len * sizeof(WCHAR) );
*view = (MSIVIEW*)tv;
}
else if (r != ERROR_SUCCESS)
{
return r;
}
else
{
tv = (struct table_view *)*view;
}
tv->view.ops = &transform_view_ops;
@ -2847,6 +2842,7 @@ static UINT TransformView_Create( MSIDATABASE *db, string_table *st, LPCWSTR nam
{
MSI_ViewClose( q );
msiobj_release( &q->hdr );
*view = (MSIVIEW *)tv;
return ERROR_SUCCESS;
}
@ -2883,6 +2879,7 @@ static UINT TransformView_Create( MSIDATABASE *db, string_table *st, LPCWSTR nam
memcpy( colinfo, tv->columns, tv->num_cols * sizeof(*colinfo) );
tv->columns = colinfo;
tv->num_cols += add_col;
*view = (MSIVIEW *)tv;
return ERROR_SUCCESS;
}