mirror of
https://gitlab.freedesktop.org/wayland/weston
synced 2024-07-09 04:15:47 +00:00
e776f2a4d9
Previously weston_config_section_get_uint was serving dual purpose for parsing both unsigned decimal integer values (ids, counts, seconds, etc.) and hexadecimal values (colors), by relying on strtoul's auto-detection mechanism. However, this usage is unable to catch certain kinds of error conditions, such as specifying a negative number where an unsigned should be used. And for colors in particular, it would misparse hex values if the leading 0x was omitted. E.g. "background-color=99999999" would render a near-black background (effectively 0x05f5e0ff) instead of medium grey, and "background-color=ffffffff" would be treated as an error rather than white. "background-color=0x01234567", "background-color=01234567", and "background-color=1234567" each resulted in the value being parsed as hexadecimal, octal, and decimal respectively, resulting in colors 0x01234567, 0x00053977, and 0x0012d687 being displayed. This new routine forces hexadecimal to be used in all cases when parsing color values, so "0x01234567" and "01234567" result in the same color value, "99999999" is grey, and "ffffffff" is white. It also requires exactly 8 or 10 digits (other lengths likely indicate typos), or the value "0" (black). Signed-off-by: Bryce Harrington <bryce@osg.samsung.com> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> |
||
|---|---|---|
| .. | ||
| cairo-util.c | ||
| cairo-util.h | ||
| config-parser.c | ||
| config-parser.h | ||
| file-util.c | ||
| file-util.h | ||
| frame.c | ||
| helpers.h | ||
| image-loader.c | ||
| image-loader.h | ||
| matrix.c | ||
| matrix.h | ||
| option-parser.c | ||
| os-compatibility.c | ||
| os-compatibility.h | ||
| platform.h | ||
| timespec-util.h | ||
| xalloc.c | ||
| xalloc.h | ||
| zalloc.h | ||