system/weston
system/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston synced 2024-07-05 17:29:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

xwm: remove configure_source on destroy

Browse Source 
It would lead to use-after-free if there was a pending idle callback to
weston_wm_window_configure() when the weston_wm_window gets destroyed. Make
sure the callback will not fire.

Found by inspection.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
This commit is contained in:
Pekka Paalanen 2019-12-05 16:42:48 +02:00 committed by Daniel Stone
parent a24989e47b
commit dcd2b420a6
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xwayland/window-manager.c
View File

@ -1514,6 +1514,8 @@ weston_wm_window_destroy(struct weston_wm_window *window)
weston_output_weak_ref_clear(&window->legacy_fullscreen_output);
if (window->configure_source)
wl_event_source_remove(window->configure_source);
if (window->repaint_source)
wl_event_source_remove(window->repaint_source);
if (window->cairo_surface)