system/weston
system/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston synced 2024-07-22 11:14:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

data-device: cleanup after touch drag

Browse source 
This change fixes the "touch-up" operation to clear "data_source"
by setting "seat" to NULL.  This operation is done in the mouse button
release operation, but seems to have been forgotten in the "touch up"
case.

Forgetting this operation causes weston to send a "premature finish
request" error to the client which causes the client to exit.

This issue can be reproduced with the "weston-dnd" program by performing
a drag-and-drop operation with a touch input device. Once the drag
is released, the weston-dnd program will exit with an error.

Signed-off-by: Jonathan Marler <johnnymarler@gmail.com>
This commit is contained in:
Jonathan Marler 2021-04-22 21:25:18 -06:00 committed by Daniel Stone
parent 5ba5a86a7f
commit d3223cc4b4
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libweston/data-device.c
View file

@ -757,8 +757,10 @@ drag_grab_touch_up(struct weston_touch_grab *grab,
if (touch_drag->base.focus_resource)
wl_data_device_send_drop(touch_drag->base.focus_resource);
if (touch_drag->base.data_source)
if (touch_drag->base.data_source) {
touch_drag->base.data_source->seat = NULL;
wl_list_remove(&touch_drag->base.data_source_listener.link);
}
data_device_end_touch_drag_grab(touch_drag);
}