system/weston
system/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston synced 2024-07-22 11:14:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

backend-drm: Don't leak writeback-format property blob

Browse source 
We were freeing the writeback-format blob on error, but not on success.

Signed-off-by: Daniel Stone <daniels@collabora.com>
This commit is contained in:
Daniel Stone 2023-05-03 10:18:18 +01:00
parent 2896a0e9ab
commit be55909779
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
libweston/backend-drm/drm.c
View file

@ -2796,6 +2796,7 @@ drm_writeback_populate_formats(struct drm_writeback *wb)
drmModePropertyBlobPtr blob;
uint32_t *blob_formats;
unsigned int i;
int ret = 0;
blob_id = drm_property_get_value(&info[WDRM_CONNECTOR_WRITEBACK_PIXEL_FORMATS],
props, 0);
@ -2808,16 +2809,17 @@ drm_writeback_populate_formats(struct drm_writeback *wb)
blob_formats = blob->data;
for (i = 0; i < blob->length / sizeof(uint32_t); i++)
for (i = 0; i < blob->length / sizeof(uint32_t); i++) {
if (!weston_drm_format_array_add_format(&wb->formats,
blob_formats[i]))
goto err;
blob_formats[i])) {
ret = -1;
break;
}
}
return 0;
err:
drmModeFreePropertyBlob(blob);
return -1;
return ret;
}
/**