From a65d55e13393bd4ecb8c02caf9620b2c1bc02d29 Mon Sep 17 00:00:00 2001 From: Daniel Stone Date: Fri, 21 Sep 2018 16:57:13 +0100 Subject: [PATCH] gl-renderer: Remove warning on missing extensions Not having swap_buffers_with_damage could cause a performance impact on some backends, but at least on GBM it causes no issues. It also seems to confuse users into thinking it's a legitimate error which could explain session slowness. Similarly with buffer_age, whilst we do lose a little bit of performance by not being able to do partial renders, it is not a great deal, and the user is unlikely to be able to do anything about it in any event. Remove the warning; we print the full extension list at startup, so we already have enough information from the logs to easily diagnose any real errors. Signed-off-by: Daniel Stone --- libweston/gl-renderer.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index 95cbc22e..b6f32737 100644 --- a/libweston/gl-renderer.c +++ b/libweston/gl-renderer.c @@ -3235,9 +3235,6 @@ gl_renderer_setup_egl_extensions(struct weston_compositor *ec) if (weston_check_egl_extension(extensions, "EGL_EXT_buffer_age")) gr->has_egl_buffer_age = 1; - else - weston_log("warning: EGL_EXT_buffer_age not supported. " - "Performance could be affected.\n"); for (i = 0; i < ARRAY_LENGTH(swap_damage_ext_to_entrypoint); i++) { if (weston_check_egl_extension(extensions, @@ -3248,11 +3245,6 @@ gl_renderer_setup_egl_extensions(struct weston_compositor *ec) break; } } - if (!gr->swap_buffers_with_damage) - weston_log("warning: neither %s or %s is supported. " - "Performance could be affected.\n", - swap_damage_ext_to_entrypoint[0].extension, - swap_damage_ext_to_entrypoint[1].extension); if (weston_check_egl_extension(extensions, "EGL_KHR_no_config_context") || weston_check_egl_extension(extensions, "EGL_MESA_configless_context"))