system/weston
system/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston synced 2024-07-22 11:14:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tests: fix leaks in bad-buffer

Browse source 
Fixes all ASan reported leaks for this test.

If frame_callback_wait_nofail() returns before the callback is handled,
the callback is not destroyed automatically. This happens on a protocol
error. This test intentionally triggers a protocol error.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
This commit is contained in:
Pekka Paalanen 2021-06-11 16:54:12 +03:00 committed by Pekka Paalanen
parent b0eb059818
commit 819054ceac
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tests/bad-buffer-test.c
View file

@ -170,6 +170,7 @@ TEST(test_truncated_shm_file)
struct client *client;
struct wl_buffer *bad_buffer;
struct wl_surface *surface;
struct wl_callback *frame_cb;
int frame;
client = create_client_and_test_surface(46, 76, 111, 134);
@ -180,10 +181,14 @@ TEST(test_truncated_shm_file)
wl_surface_attach(surface, bad_buffer, 0, 0);
wl_surface_damage(surface, 0, 0, 200, 200);
frame_callback_set(surface, &frame);
frame_cb = frame_callback_set(surface, &frame);
wl_surface_commit(surface);
frame_callback_wait_nofail(client, &frame);
if (!frame_callback_wait_nofail(client, &frame))
wl_callback_destroy(frame_cb);
expect_protocol_error(client, &wl_buffer_interface,
WL_SHM_ERROR_INVALID_FD);
wl_buffer_destroy(bad_buffer);
client_destroy(client);
}