system/weston
system/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston synced 2024-10-06 18:05:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

xwayland: Don't leak fds on failure

Browse source 
Trivial fixup to not leak socketpairs if we need to exit early in the
function.

Signed-off-by: Daniel Stone <daniels@collabora.com>
This commit is contained in:
Daniel Stone 2022-07-21 17:15:18 +01:00 committed by Pekka Paalanen
parent c0a75ee379
commit 4e6a978e34
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
compositor/xwayland.c
View file

@ -120,13 +120,13 @@ spawn_xserver(void *user_data, const char *display, int abstract_fd, int unix_fd
if (os_socketpair_cloexec(AF_UNIX, SOCK_STREAM, 0, x11_wm_socket.fds) < 0) {
weston_log("X wm connection socketpair failed\n");
return 1;
goto err_wayland_socket;
}
fdstr_update_str1(&x11_wm_socket);
if (pipe2(display_pipe.fds, O_CLOEXEC) < 0) {
weston_log("pipe creation for displayfd failed\n");
return 1;
goto err_x11_wm_socket;
}
fdstr_update_str1(&display_pipe);
@ -217,6 +217,12 @@ spawn_xserver(void *user_data, const char *display, int abstract_fd, int unix_fd
free(xserver);
return pid;
err_x11_wm_socket:
fdstr_close_all(&x11_wm_socket);
err_wayland_socket:
fdstr_close_all(&wayland_socket);
return -1;
}
static void