system/weston
system/weston
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/weston synced 2024-10-03 02:09:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

xwm: explain the read_properties() in xserver_map_shell_surface()

Browse source 
To me it was not obvious that this call is necessary, so provide some
rationale.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Daniel Stone <daniels@collabora.com>
This commit is contained in:
Pekka Paalanen 2016-12-21 13:41:34 +02:00
parent 9f5a103188
commit 0bbe624bfb
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
xwayland/window-manager.c
View file

@ -2659,6 +2659,15 @@ xserver_map_shell_surface(struct weston_wm_window *window,
wm->server->compositor->xwayland_interface;
struct weston_wm_window *parent;
/* This should be necessary only for override-redirected windows,
* because otherwise MapRequest handler would have already updated
* the properties. However, if X11 clients set properties after
* sending MapWindow, here we can still process them. The decorations
* have already been drawn once with the old property values, so if the
* app changes something affecting decor after MapWindow, we glitch.
* We only hit xserver_map_shell_surface() once per MapWindow and
* wl_surface, so better ensure we get the window type right.
*/
weston_wm_window_read_properties(window);
/* A weston_wm_window may have many different surfaces assigned