systemd/coccinelle/no-if-assignments.cocci at ee7561d014d073944779e155271d7042d7ea5572 - system/systemd - HydraGit

system/systemd

mirror of https://github.com/systemd/systemd synced 2024-11-05 18:25:39 +00:00

Lennart Poettering 3cc2aff1ab tree-wide: don't do assignments within if checks

Turn this:

       if ((r = foo()) < 0) { ...

into this:

       r = foo();
       if (r < 0) { ...

2015-09-09 08:20:20 +02:00

20 lines

200 B

Text

Raw Blame History

 @@
 expression p, q;
 identifier r;
 statement s;
 @@
 - if ((r = q) < p)
 - s
 + r = q;
 + if (r < p)
 + s
 @@
 expression p, q;
 identifier r;
 statement s;
 @@
 - if ((r = q) >= p)
 - s
 + r = q;
 + if (r >= p)
 + s