systemd/coccinelle/empty-to-null.cocci at ee7561d014d073944779e155271d7042d7ea5572 - system/systemd - HydraGit

system/systemd

mirror of https://github.com/systemd/systemd synced 2024-11-05 18:25:39 +00:00

Frantisek Sumsal 60d9959dd8 coccinelle: ignore function transformations causing recursion

For example, following transformation:

- isempty(s) ? NULL : s
+ empty_to_null(s)

would get applied to the empty_to_null function itself as well,
causing an infinite recursion, like:

--- src/basic/string-util.h
+++ /tmp/cocci-output-307-9f76e6-string-util.h
@@ -50,11 +50,11 @@ static inline bool isempty(const char *p
 }

 static inline const char *empty_to_null(const char *p) {
-        return isempty(p) ? NULL : p;
+        return empty_to_null(p);
 }

Let's avoid that by checking the current match position

2019-04-29 15:38:53 +02:00

8 lines

217 B

Text

Raw Blame History

 @@
 /* Avoid running this transformation on the empty_to_null function itself */
 position p : script:python() { p[0].current_element != "empty_to_null" };
 expression s;
 @@
 - isempty@p(s) ? NULL : s
 + empty_to_null(s)