78103450b4
This changes the generated config.h file thusly: -#define _GNU_SOURCE +#define _GNU_SOURCE 1 Canonically, _GNU_SOURCE is just defined, without any value, but g++ defines _GNU_SOURCE implicitly [1]. This causes a warning about a redefinition during complilation of C++ programs after '-include config.h'. Our config attempts to inject this (and a bunch of other arguments) into all compliations. But before meson 0.54, flags for dependencies were not propagated correctly (*), and the C++ compilation was done without various flags (**). Once that was fixed, we started getting a warning. [1] http://gcc.gnu.org/onlinedocs/libstdc++/faq.html#faq.predefined (*) Actually, the changelog doesn't say anything. But it mentions various work related to dependency propagation, and apparently this changes as a side effect. (**) -fno-strict-aliasing -fstrict-flex-arrays=1 -fvisibility=hidden -fno-omit-frame-pointer -include config.h This could be solved in various ways, but it'd require either making the compilation command line longer, which we want to avoid for readability of the build logs, or splitting the logic to define the args for C++ progs separately, which would make our meson.build files more complicated. Changing the definition to '1' also solves the issue (because apparently now we match the implicit definition), and shouldn't have other effects. I checked compilation with gcc and clang. Maybe on other systems this could cause problems. We can revisit if people report issues. |
||
|---|---|---|
| .clusterfuzzlite | ||
| .github | ||
| .semaphore | ||
| catalog | ||
| coccinelle | ||
| docs | ||
| factory | ||
| hwdb.d | ||
| LICENSES | ||
| man | ||
| mkosi.conf.d | ||
| mkosi.presets | ||
| modprobe.d | ||
| network | ||
| po | ||
| presets | ||
| rules.d | ||
| shell-completion | ||
| src | ||
| sysctl.d | ||
| sysusers.d | ||
| test | ||
| tmpfiles.d | ||
| tools | ||
| units | ||
| xorg | ||
| .clang-format | ||
| .ctags | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .packit.yml | ||
| .vimrc | ||
| .ycm_extra_conf.py | ||
| configure | ||
| LICENSE.GPL2 | ||
| LICENSE.LGPL2.1 | ||
| Makefile | ||
| meson.build | ||
| meson_options.txt | ||
| mkosi.kernel.config | ||
| NEWS | ||
| README | ||
| README.md | ||
| TODO | ||
System and Service Manager
Details
Most documentation is available on systemd's web site.
Assorted, older, general information about systemd can be found in the systemd Wiki.
Information about build requirements is provided in the README file.
Consult our NEWS file for information about what's new in the most recent systemd versions.
Please see the Code Map for information about this repository's layout and content.
Please see the Hacking guide for information on how to hack on systemd and test your modifications.
Please see our Contribution Guidelines for more information about filing GitHub Issues and posting GitHub Pull Requests.
When preparing patches for systemd, please follow our Coding Style Guidelines.
If you are looking for support, please contact our mailing list or join our IRC channel.
Stable branches with backported patches are available in the stable repo.