mirror of
https://github.com/systemd/systemd
synced 2024-09-06 16:56:43 +00:00
![Nick Rosbrook](/assets/img/avatar_default.png)
Commit 70e74a5997
("pstore: Run after modules are loaded") added After=
and Wants= entries for all known kernel modules providing a pstore.
While adding these dependencies on systems where one of the modules is
not present, or not configured, should not have a real affect on the
system, it can produce annoying error messages in the kernel log. E.g.
"mtd device must be supplied (device name is empty)" when the mtdpstore
module is not configured correctly.
Since dependencies cannot be removed with drop-ins, if a distro wants to
remove some of these modules from systemd-pstore.service, they need to
patch units/systemd-pstore.service.in. On the other hand, if they want
to append to the dependencies this can be done by shipping a drop-in.
Since the original intent of the previous commit was to fix [1], which
only requires the efi_pstore module, remove all other kernel module
dependencies from systemd-pstore.service, and let distros ship drop-ins
to add dependencies if needed.
[1] https://github.com/systemd/systemd/issues/18540
29 lines
817 B
SYSTEMD
29 lines
817 B
SYSTEMD
# SPDX-License-Identifier: LGPL-2.1-or-later
|
|
#
|
|
# This file is part of systemd.
|
|
#
|
|
# systemd is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU Lesser General Public License as published by
|
|
# the Free Software Foundation; either version 2.1 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
[Unit]
|
|
Description=Platform Persistent Storage Archival
|
|
Documentation=man:systemd-pstore(8)
|
|
ConditionDirectoryNotEmpty=/sys/fs/pstore
|
|
ConditionVirtualization=!container
|
|
DefaultDependencies=no
|
|
Conflicts=shutdown.target
|
|
Before=sysinit.target shutdown.target
|
|
After=modprobe@efi_pstore.service
|
|
Wants=modprobe@efi_pstore.service
|
|
|
|
[Service]
|
|
Type=oneshot
|
|
ExecStart={{ROOTLIBEXECDIR}}/systemd-pstore
|
|
RemainAfterExit=yes
|
|
StateDirectory=systemd/pstore
|
|
|
|
[Install]
|
|
WantedBy=sysinit.target
|