Commit graph

73573 commits

Author SHA1 Message Date
Mike Yuan b5636a8f83
debug-generator: enclose function call in if statement when retval
is not used
2024-05-08 18:43:49 +08:00
Daan De Meyer 904b8ae47a TEST-04-JOURNAL: Sleep more in delegated cgroup filtering script
We already changed logs-filtering.service to sleep 2 seconds before
exiting to combat flakyness, let's do the same for the delegated
cgroup filtering payload.

Fixes #32696 (hopefully)
2024-05-08 12:27:35 +02:00
Daan De Meyer 65690de6f9 TEST-81-GENERATORS: Do a lazy unmounts
Otherwise we might fail if PID 1 is currently accessing these files.

Fixes #32692 (hopefully)
2024-05-08 12:27:24 +02:00
Mike Yuan a688e5fefd
ssh-generator: fix pointer cast type 2024-05-08 18:20:59 +08:00
Lennart Poettering cd7c207795 tree-wide: add dlopen ELF notes to all dlopen() deps of ours
Use 'recommended' priority for the default compression library, to
indicate that it should be prioritized over the other ones, as it
will be used to compress journals/core files.
Also use 'recommended' for kmod, as systems will likely fail to boot
if it's missing from the initrd.
Use 'suggested' for everything else.

There is one dlopen'ed TPM library that has the name generated
at runtime (depending on the driver), so that cannot be added, as it
needs to be known at build time.
Also when we support multiple ABI versions list them all, as for the
same reason we cannot know which one will be used at build time.

$ dlopen-notes.py build/libsystemd.so.0.39.0 build/src/shared/libsystemd-shared-256.so
libarchive.so.13 suggested
libbpf.so.0 suggested
libbpf.so.1 suggested
libcryptsetup.so.12 suggested
libdw.so.1 suggested
libelf.so.1 suggested
libfido2.so.1 suggested
libgcrypt.so.20 suggested
libidn2.so.0 suggested
libip4tc.so.2 suggested
libkmod.so.2 recommended
liblz4.so.1 suggested
liblzma.so.5 suggested
libp11-kit.so.0 suggested
libpcre2-8.so.0 suggested
libpwquality.so.1 suggested
libqrencode.so.3 suggested
libqrencode.so.4 suggested
libtss2-esys.so.0 suggested
libtss2-mu.so.0 suggested
libtss2-rc.so.0 suggested
libzstd.so.1 recommended

Co-authored-by: Luca Boccassi <bluca@debian.org>
2024-05-08 11:07:36 +01:00
Lennart Poettering 2f6bd11c1a dlfcn: add macro for exporting dlopen() module names in ELF sections
This allows code to declare "weak" dlopen() style deps via an ELF
section following the just added specification.

The idea is that any user of dlopen() will place ELF_NOTE_DLOPEN(…)
somewhere close which will synthesize the note.

Tools such as rpm/dpkg package builders as well as initrd generators
(such as dracut) can then automatically pick up these weak deps of
suggested dependencies for their purposes.

Co-authored-by: Luca Boccassi <bluca@debian.org>
2024-05-08 11:07:36 +01:00
Luca Boccassi cb7e3126b9 docs: add specification for ELF dlopen metadata
Tool to parse it and to use it for Debian packaging available at
https://github.com/systemd/package-notes

Add 3 levels of priority like Debian does, but using terminology
from RPM as it seems more apt.
We will very likely never use 'required', as we use this functionality
for optional features, but it is worth having it in the spec nonetheless
as we want it to be generalized.
2024-05-08 11:07:36 +01:00
Daan De Meyer 677430b3c7 tmpfiles: Don't fail if file does not exist in item_do()
If the file was removed by some other program, we should just go
to the next one without failing. item_do() is only used for recursive
globs instead of fixed paths so skipping on missing files makes sense
(unlike if the path was fixed where we should probably fail).

Fixes #32691 (hopefully)
2024-05-08 12:01:37 +02:00
Daan De Meyer a35edc9ad4 TEST-74-AUX-UTILS: Make more robust
Let's run mkfs on the file we create instead of the loop device and
let's use udevadm wait --settle to wait for udev to settle before
doing anything with the loop device

Fixes #32680 (hopefully)
2024-05-08 11:35:15 +02:00
Sam Leonard 1f815bf164 machined: add GetMachineSSHInfo method
Also adds three properties:
- VsockCid: the VSOCK CID of the VM
- SshAddress: the address of the VM in a format SSH can connect to
- SshPrivateKeyPath: the path to the SSH private key to use to connect
  to the VM.

GetMachineSSHInfo is essentially a convenience method to query both the
SshAddress and SshPrivateKeyPath properties at once.
2024-05-08 09:56:42 +01:00
Sam Leonard 885317f1ab machined: split manager linking out of machine_new into machine_link 2024-05-08 09:52:15 +01:00
Sam Leonard 71a15f37af machined: expose machine_freep in machine.h 2024-05-08 09:52:15 +01:00
Sam Leonard 8fcf504b8c shared/json: add json_dispatch_absolute_path 2024-05-08 09:52:15 +01:00
Daan De Meyer b438ebd7bc TEST-07-PID1: Fix race in aux-scope subtest
Currently test-aux-scope.service can get killed by the test before
it's had a chance to setup its signal handler. Make it Type=notify
to fix the race.

Fixes #32670 (hopefully)
2024-05-08 10:20:20 +02:00
Mike Yuan 18303adcd3 man/run0: remove the --user example for --machine=
run0's --user= option is different from other tools,
and the whole point of run0 is to connect to the system
manager. So the example is spurious.
2024-05-08 10:08:53 +02:00
Zbigniew Jędrzejewski-Szmek a4f0e0da35 preset-all: continue on errors, report more errors
Firstly, if we encounter an error when iterating over the directory, gather
the error but continue. This is unlikely to happen, but if it happens, then
it doesn't seem very useful to break the preset processing at a random
point. If we can't process a unit — too bad, but since we already might
have processed some units earlier, we might as well try to process the
remaining ones.

Secondly, add missing error codes for units that are in a bad state to the
exclusion list. Those, we report them in the changes list, but consider the
whole operation a success. (-ETXTBSY and -ENOLINK were missing.)

Thirdly, add a message generator for -ENOLINK.

Fixes https://github.com/systemd/systemd/issues/21224.
2024-05-08 08:18:55 +02:00
Mike Yuan 4f344de792
systemctl: do not fall back to StartUnit automatically for sleep operations
In the majority of cases, this is caused by
sleep_supported() returning error. Hence it's
very likely that it would fail again, so
the fallback is not really useful. Instead,
honor the --force option for these verbs.
2024-05-08 13:45:49 +08:00
Mike Yuan 3fce141c1b
hibernate-util,logind: also differentiate the case of misconfigured resume 2024-05-08 12:55:25 +08:00
Mike Yuan 40eb83a8fe
hibernate-util,logind: emit a clear error if the specified resume dev is missing
Currently, SLEEP_NOT_ENOUGH_SWAP_SPACE (ENOSPC) is returned
on all sorts of error conditions. But one important case
that's worth differentiating from that is when the resume device
is manually specified yet missing.

Closes #32644
2024-05-08 12:54:13 +08:00
Luca Boccassi 3473c842fa
Merge pull request #32684 from YHNdnzj/pr-followups
Follow-ups for recently merged PRs
2024-05-07 21:05:04 +02:00
Daan De Meyer 4c4b7ee5db
Merge pull request #32681 from DaanDeMeyer/skipped-no-journal
test: Don't keep journals for skipped tests
2024-05-07 20:49:49 +02:00
Daan De Meyer 0d13ca5544 test: Mark TEST-21-DFUZZER as slow and skip it by default
The test is not really useful without sanitizers, so let's mark it
as slow and not run it by default in CI.
2024-05-07 19:06:42 +02:00
Daan De Meyer f1f87f3b2e test: Add infra to mark integration tests as slow
Some integration tests take much more time than others, let's add
a test param that can be used to configure this and integrate it
with the slow-tests meson option.
2024-05-07 19:06:42 +02:00
Daan De Meyer a77f65d0c9 ci: Print a helpful link to download and view a failed test's journal 2024-05-07 19:06:39 +02:00
Mike Yuan 8aed85875d
repart: correct timespec_store usage too 2024-05-08 00:19:38 +08:00
Mike Yuan 158681f0f9
basic/mkdir: use timespec_store instead of _nsec for mkdir_p_root_full
Follow-up for 34c3d57474

O_RDONLY is dropped when O_DIRECTORY is specified, since
it's unnecessary and even arguably confusing here, as
the dir is modified.
2024-05-08 00:18:27 +08:00
Mike Yuan 026335e9aa
core/service: use switch for service_enter_start
Plus, add an assertion to ensure we're actually
using the start timestamp for the correct pid.
2024-05-08 00:17:54 +08:00
Mike Yuan dddc060286
core/execute: re-break function declaration of exec_spawn
Also rearrange some variable definitions. Note that
DECIMAL_STR_MAX() contains the size of NUL byte,
so +1 is dropped.
2024-05-08 00:16:54 +08:00
Mike Yuan 06c0f569e9
core/unit: use FOREACH_STRING where appropriate
Follow-up for 61628287bd
2024-05-08 00:16:36 +08:00
Daan De Meyer 5dd3657f86 ci: Optimize pull request labeler
We keep running into rate limits, so let's optimize the number of
requests we do in the pull request labeler to hopefully fix that.
2024-05-07 17:49:54 +02:00
Daan De Meyer ca2e19f2b7 test: Don't keep journals for skipped tests
Let's make sure we don't save journals for tests that were skipped.
2024-05-07 17:34:42 +02:00
Luca Boccassi 1213fc94b4
Merge pull request #32683 from dtardon/fix-error-vars
More mismatched error variables
2024-05-07 17:19:54 +02:00
Daan De Meyer 388e70db07 mkosi: Update centos submodule to latest 2024-05-07 17:15:10 +02:00
Mike Yuan 6b34871f5d
core/exec-credential: complain louder if inherited credential is missing
Also document that a missing inherited credential
is not considered fatal.

Closes #32667
2024-05-07 22:02:42 +08:00
Mike Yuan d568c4c1a8
core/load-fragment: modernize config_parse_load_credential a bit 2024-05-07 21:58:16 +08:00
David Tardon cd35c15de3 clean-ipc: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon 75c64e58d1 udev-rules: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon 2c30973f0b homework-quota: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon 6c936c156a homework-blob: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon 11bbc1f8b8 homework-fscrypt: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon bc65a5e37d homed-manager: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon 3a5046782e test-bpf-foreign-programs: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon 2dd1676fa7 test-bpf-restrict-fs: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon 1174ebb45f test-socket-bind: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon 192a452d1c nspawn: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon 3613a1d49f userns-restrict: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon 422aa53123 cgroup-show: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon af1690cfcc manager: pass the right error variable 2024-05-07 14:02:08 +02:00
David Tardon be6aa742a6 resolved-dns-stream: pass the right error variable 2024-05-07 13:23:24 +02:00
David Tardon 6400084caa exec-invoke: pass the right error variable 2024-05-07 13:19:42 +02:00