Yu Watanabe
e30dc59c2e
network/queue: increase the reference counter of the request before processing it
...
To prevent the request freed in req->process().
This also makes a request that is not requested by a link detached on failure.
Otherwise, the request may periodically processed and failed forever.
2024-01-16 23:25:32 +09:00
Lennart Poettering
e9c974fd42
user-util: honour PREFER_NSS flag in get_group_creds() the same way as we already do in get_user_creds()
...
let's onour the PREFER_NSS flag also in get_group_creds() the same
way we honour it in get_user_creds().
Simply to remove surprises.
2024-01-16 14:56:25 +01:00
Lennart Poettering
83e9b584db
user-util: modernize get_user_creds() + get_group_creds()
...
Let's rename return parameters to ret_xyz, and let's guarantee the usual
rule to initialize all return parameters on success, and not touch any
on failure.
2024-01-16 14:55:45 +01:00
Lennart Poettering
a9e4057f1f
creds-util: drop unnecessary include
...
Follow-up for: e653a194e4
2024-01-16 14:16:42 +01:00
Lennart Poettering
cdbcb1fe6e
creds-util: simplify offset calculation a bit
...
Don't recalculate the overall offset entirely each time we process
another header. Instead, if we already validated an earlier offset, just
reuse the result, it's readily available in 'p'.
No change in behaviour, just a bit of code simplification.
2024-01-16 14:16:18 +01:00
Lennart Poettering
e96202fa5d
bus-polkit: don't return positive in varlink_verify_polkit_async() just because we already sent an error reply
...
A positive return value means "access granted", hence if we already
reply to the method call don't accidentally return positive.
Follow-up for: d04c1a1c8e
2024-01-16 13:59:49 +01:00
Lennart Poettering
0ca9a44799
bus-polkit: explicitly cast away return value we ignore
2024-01-16 13:59:49 +01:00
Lennart Poettering
956d8aee01
bus-polkit: treat various well-known PK errors as denied
...
Various recognizable errors from
https://www.freedesktop.org/software/polkit/docs/latest/eggdbus-interface-org.freedesktop.PolicyKit1.Authority.html#eggdbus-errordomain-org.freedesktop.PolicyKit1.Error .
should be considered access failures, hence treat them like that.
2024-01-16 13:59:49 +01:00
Lennart Poettering
4a6fe5f05e
varlink: also honour new env var $SYSTEMD_VARLINK_LISTEN in varlink_server_listen_auto()
...
varlink_server_listen_auto() is supposed to be the one-stop solution for
turning simple command line tools into IPC services. They aren't easy to
test/debug however, since you have to invoke them through a service
manager.
Let's make this easier: if the SYSTEMD_VARLINK_LISTEN env var is set,
let's listen on the socket specified therein. This makes things easier
to gdb: just run the service from the cmdline.
2024-01-16 13:45:35 +01:00
Lennart Poettering
1752a8ee33
varlink-idl: prefix all varlink IDL debug lines wit "Varlink-IDL:"
...
Let's improve debuggability of varlink IPC transactions, and separate
out log messages triggered by the IPC info from others, by prefixing
them with a specific prefix.
2024-01-16 13:44:21 +01:00
Luca Boccassi
c5ff54c40f
Merge pull request #30953 from yuwata/network-nexthop-silently-removed-by-kernel
...
network/nexthop: forget nexthops silently removed by kernel
2024-01-16 12:39:46 +00:00
Yu Watanabe
3518ff4a42
network/route: introduce route_get_link() and use it in log_route_debug()
...
No functional change, just refactoring and preparation for later
commits.
2024-01-16 12:35:58 +00:00
Sam Leonard
773ca1def8
vmspawn: supply a serial TTY to the kernel by default
2024-01-16 10:08:35 +00:00
Sam Leonard
0f2b492f51
vmspawn: ignore firmwares with enrolled-keys by default
2024-01-16 10:08:34 +00:00
我超厉害
8a86e15f07
udev: even if a device is a zac device, scsi-$ID_SERIAL will be reserved for it ( #30459 )
...
Co-authored-by: wangyuhang <wangyuhang27@huawei.com>
2024-01-16 14:57:07 +09:00
Yu Watanabe
f8a6fc51a6
Merge pull request #30851 from lnussel/kernel-install
...
kernel-install fixes
2024-01-16 14:55:35 +09:00
Daan De Meyer
16e4efa7d3
tree-wide: Load entry-token and layout.conf from /usr/lib/kernel/ as well
2024-01-16 14:54:04 +09:00
Yu Watanabe
f9b5c27645
test-network: add test case for removal of nexthop that is a member of a group nexthop
2024-01-16 12:48:50 +09:00
Yu Watanabe
3cbbe8635a
network/nexthop: drop dependent nexthops on removal
...
If a nexthop is removed, dependent nexthops are silently removed by the
kernel. Hence, networkd may be confused that nexthops that depends on the
nexthop still exist, and may fail to configure other routes or so.
2024-01-16 12:48:50 +09:00
Yu Watanabe
531c724682
network/nexthop: introduce a reverse map of nexthop group members
...
It is not used in this commit, but will be used later.
Preparation for later commits.
2024-01-16 12:48:50 +09:00
Yu Watanabe
4e9795ebfa
network/nexthop: read netlink message in nexthop_update_group()
...
No functional change, preparation for later commits.
2024-01-16 12:48:50 +09:00
Yu Watanabe
04a25cc425
network/nexthop: reorder elements in NextHop
2024-01-16 12:48:50 +09:00
Yu Watanabe
0a94e19c72
network/route: trivial cosmetic changes
...
- downgrade log level,
- add short comment for boolean argument.
2024-01-16 11:45:14 +09:00
Yu Watanabe
0013863972
network/route: reorder getters in manager_rtnl_process_route()
...
No functional change, just refactoring and preparation for later
commits.
2024-01-16 11:02:55 +09:00
Yu Watanabe
31b26dee4f
network/route: reorder setter called in route_set_netlink_message()
...
Also, this renames 'req' -> 'm', and makes the function unconditionally
set route type and route metric, and override type later if necessary.
Should not change any effective behavior. Just refactoring.
2024-01-16 11:02:55 +09:00
Yu Watanabe
e717b825d4
network/route: reorder elements in Route object and add comments
2024-01-16 11:02:55 +09:00
Yu Watanabe
1bcd7cd0e7
network/route: relocate route_new() and friends
...
No functional change, preparation for later commits.
2024-01-16 11:02:55 +09:00
Daan De Meyer
0e2f18eedd
bus-socket: Clarify that inotify is supposed to watch all components
...
The previous wording of the components could mean that we should only
watch directories, not the socket itself. Reword so that we clearly
mention that all components of the path are watched, including the
socket itself.
2024-01-15 17:00:04 +00:00
Ludwig Nussel
ec9ff6ea94
kernel-install: silence num kernels installed
2024-01-15 17:16:37 +01:00
Ludwig Nussel
27d420f466
kernel-install: fix context_copy
...
Don't reopen or dup values that weren't set before. Fixes add-all.
2024-01-15 17:16:37 +01:00
Ludwig Nussel
5058bd7e1f
strv: introduce strv_copy_unless_empty()
2024-01-15 17:16:37 +01:00
Luca Boccassi
01526fedef
Merge pull request #30934 from yuwata/network-introduce-route-nexthop
...
network/route: introduce RouteNextHop object
2024-01-15 14:41:58 +00:00
Antonio Alvarez Feijoo
b551a687a4
systemctl-is-system-running: display "offline" with --image
...
With the `--image` option, the `running_in_chroot` check is not enough. E.g.:
```
> build/systemctl --image /tmp/20240108-openSUSE.raw is-system-running
running
```
2024-01-15 11:58:38 +00:00
Yu Watanabe
a663ddc04e
test-network: add simple test case for DHCP relay on bridge interface
...
For issue #30763 .
2024-01-15 10:53:07 +00:00
Yu Watanabe
3db1e6a874
resolve: on_transaction_stream_error() may free multiple transactions
...
Fixes #30928 .
2024-01-15 10:36:14 +00:00
Luca Boccassi
af8d919dcb
Merge pull request #30933 from YHNdnzj/sleep-trivial-cleanup
...
Trivial cleanup for systemd-sleep unit/man page
2024-01-15 10:15:12 +00:00
Luca Boccassi
dd3f119b98
Merge pull request #30936 from yuwata/network-automatically-reconfigure-interface-on-failure
...
network: automatically reconfigure interface on failure
2024-01-15 10:09:30 +00:00
Yu Watanabe
6d1cea7bc6
test-network: try to flip interface state frequently
2024-01-15 15:46:33 +09:00
Yu Watanabe
c2eb7753dd
network/link: automatically reconfigure interface on failure
...
Closes #29246 .
2024-01-15 15:46:33 +09:00
Yu Watanabe
24b9c341ce
network/link: shorten code a bit
2024-01-15 15:46:33 +09:00
Yu Watanabe
13efe0ab11
network/route: do not read RTA_OIF twice
...
It is also read in route_nexthops_read_netlink_message(), and already
stored in the Route object. Let's use it.
2024-01-15 10:28:25 +09:00
Yu Watanabe
b9e1caf64a
network/route-nexthop: store ifindex of the assigned interface in Route.nexthop.ifindex
...
And use it if set on building netlink message.
2024-01-15 10:28:25 +09:00
Yu Watanabe
054b8c2817
network/route: also use RouteNextHop for managing gateway
...
No functional change, just refactoring.
2024-01-15 10:28:25 +09:00
Yu Watanabe
fea879cd04
network/route-nexthop: introduce struct RouteNextHop and replace MultipathRoute with it
...
It is mostly equivalent to MultipathRoute. So, no functional change,
just refactoring and preparation for later commits.
2024-01-15 10:28:25 +09:00
Luca Boccassi
0f6a6e2f2b
test: create /run/sshd in TEST-74-AUX-UTILS
...
12264s [ 4819.948632] sshd[1365]: fatal: Missing privilege separation directory: /run/sshd
12264s [ 4819.952120] testsuite-74.sh[1362]: kex_exchange_identification: read: Connection reset by peer
12264s [ 4819.952120] testsuite-74.sh[1362]: Connection reset by /run/ssh-unix-local/socket port 0
https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-upstream-systemd-ci-systemd-ci/jammy/amd64/s/systemd-upstream/20240113_093341_50fc7@/log.gz
We copy binaries manually so some setups are missing, create the directory
as needed
2024-01-15 10:28:05 +09:00
Mike Yuan
f2723ca745
man/systemd-sleep.conf: document the operation of s2h more thoroughly
2024-01-15 03:05:25 +08:00
Mike Yuan
22b21b2ea2
units: update Description= for systemd-sleep units
2024-01-15 02:59:25 +08:00
Mike Yuan
ad0b7e03db
battery-util: raise log level for battery_is_discharging_and_low
2024-01-15 02:57:44 +08:00
Luca Boccassi
489864d3e9
Merge pull request #30932 from yuwata/network-route-split-out-more
...
network/route: split out more functions to networkd-route-nexthop.[ch]
2024-01-14 13:03:45 +00:00
Cristian Rodríguez
2a9ab0974b
Fix gcc14 -Wcalloc-transposed-args warnings
...
all functions annotated with two parameter _alloc_ are calloc-like.
gcc14 enforces this and warns if arguments are backwards.
2024-01-14 12:57:38 +00:00