system/systemd
system/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd synced 2024-07-22 10:44:58 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

core/dbus-execute: fix potential memory leak

Browse source
This commit is contained in:
Mike Yuan 2024-04-11 03:57:34 +08:00
parent f09604b0a6
commit ee9895e295
No known key found for this signature in database
GPG key ID: 417471C0A40F58B3
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/core/dbus-execute.c
View file

@ -1354,29 +1354,28 @@ int bus_set_transient_exec_command(
return r;
if (!UNIT_WRITE_FLAGS_NOOP(flags)) {
ExecCommand *c;
_cleanup_(exec_command_freep) ExecCommand *c = NULL;
c = new0(ExecCommand, 1);
c = new(ExecCommand, 1);
if (!c)
return -ENOMEM;
c->path = strdup(path);
if (!c->path) {
free(c);
return -ENOMEM;
}
*c = (ExecCommand) {
.argv = TAKE_PTR(argv),
};
c->argv = TAKE_PTR(argv);
r = path_simplify_alloc(path, &c->path);
if (r < 0)
return r;
if (ex_prop) {
r = exec_command_flags_from_strv(ex_opts, &c->flags);
if (r < 0)
return r;
} else
c->flags = b ? EXEC_COMMAND_IGNORE_FAILURE : 0;
} else if (b)
c->flags |= EXEC_COMMAND_IGNORE_FAILURE;
path_simplify(c->path);
exec_command_append_list(exec_command, c);
exec_command_append_list(exec_command, TAKE_PTR(c));
}
n++;