From d0c0c1069b65ed945820df8fd7dadeccb9ae66b0 Mon Sep 17 00:00:00 2001 From: Abderrahim Kitouni Date: Sun, 10 Sep 2023 23:41:35 +0100 Subject: [PATCH] update-dbus-docs: don't consider mentions in the History Being mentioned in the History section as added in a specific version isn't enough to consider a member documented. --- tools/update-dbus-docs.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/update-dbus-docs.py b/tools/update-dbus-docs.py index d6438a5daf..b3466bc110 100755 --- a/tools/update-dbus-docs.py +++ b/tools/update-dbus-docs.py @@ -141,10 +141,16 @@ def print_interface(iface, *, prefix, file, print_boring, only_interface, declar print(f'''{prefix}}};''', file=file) def document_has_elem_with_text(document, elem, item_repr): - predicate = f".//{elem}" # [text() = 'foo'] doesn't seem supported :( + predicate = f".//{elem}[. = '{item_repr}']" + + # Ignore mentions in the History section + history = document.find(".//refsect1[title = 'History']") + history_mentions = history.findall(predicate) if history else [] + for loc in document.findall(predicate): - if loc.text == item_repr: - return True + if loc in history_mentions: + continue + return True return False def check_documented(document, declarations, stats):