From bc2a4af25f7f7673712ff9b70822a1f68974ee4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 6 Jul 2021 15:13:00 +0200 Subject: [PATCH] meson: re-enable -Wunused-result with clang We disabled it in f73fb7b742f294b6d2126afa16001bd2ff6ab461 in response to an apparent gcc bug. It seems that depending on the combination of optimization options, gcc still ignores (void). But this seems to work fine with clang, so let's re-enable the warning conditionally. --- meson.build | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 366f2c5607..5735cfc7ad 100644 --- a/meson.build +++ b/meson.build @@ -322,7 +322,6 @@ basic_disabled_warnings = [ '-Wno-format-signedness', '-Wno-missing-field-initializers', '-Wno-unused-parameter', - '-Wno-unused-result', ] possible_common_cc_flags = [ @@ -366,6 +365,12 @@ if cc.get_id() == 'gcc' and (not '02'.contains(get_option('optimization')) or possible_common_cc_flags += '-Wno-maybe-uninitialized' endif +# Disable -Wno-unused-result with gcc, see +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425. +if cc.get_id() == 'gcc' + possible_common_cc_flags += '-Wno-unused-result' +endif + # --as-needed and --no-undefined are provided by meson by default, # run mesonconf to see what is enabled possible_link_flags = [