system/systemd
system/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd synced 2024-07-01 07:34:28 +00:00
Code Issues Projects Releases Wiki Activity

coccinelle: don't run iovec-make on iovec_done{,_erase}

Browse Source 
As the result is a bit funky (but still valid), i.e.:

 static inline void iovec_done_erase(struct iovec *iovec) {
         assert(iovec);

-        iovec->iov_base = erase_and_free(iovec->iov_base);
-        iovec->iov_len = 0;
+        *iovec = IOVEC_MAKE(erase_and_free(iovec->iov_base), 0);
 }
This commit is contained in:
Frantisek Sumsal 2023-10-25 11:16:37 +02:00
parent adabcbabff
commit b3bfb95178
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
coccinelle/iovec-make.cocci
View File

@ -13,9 +13,13 @@ expression x, p, l;
- x.iov_len = l;
+ x = IOVEC_MAKE(p, l);
@@
/* Don't run this transformation on iovec_done() and iovec_done_erase(),
* since the result, albeit correct, is a bit funky. */
position pos : script:python() { pos[0].current_element != "iovec_done" and
pos[0].current_element != "iovec_done_erase" };
expression x, p, l;
@@
- x->iov_base = p;
- x->iov_base@pos = p;
- x->iov_len = l;
+ *x = IOVEC_MAKE(p, l);
@@