system/systemd
system/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd synced 2024-07-23 19:25:39 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

nsresource: fix FD leak

Browse source 
Also fix return code, namespace_open_by_type uses RET_NERRNO

CID#1542923

Follow-up for 54452c7b2a
This commit is contained in:
Luca Boccassi 2024-04-08 02:33:27 +01:00 committed by Luca Boccassi
parent f50be1870d
commit 9dcc2a5838
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/shared/nsresource.c
View file

@ -146,15 +146,16 @@ int nsresource_register_userns(const char *name, int userns_fd) {
int nsresource_add_mount(int userns_fd, int mount_fd) {
_cleanup_(varlink_unrefp) Varlink *vl = NULL;
_cleanup_close_ int _userns_fd = -EBADF;
int r, userns_fd_idx, mount_fd_idx;
const char *error_id;
assert(mount_fd >= 0);
if (userns_fd < 0) {
int _userns_fd = namespace_open_by_type(NAMESPACE_USER);
_userns_fd = namespace_open_by_type(NAMESPACE_USER);
if (_userns_fd < 0)
return -errno;
return _userns_fd;
userns_fd = _userns_fd;
}