From 8f33bfeca1bf4da316eb4bc55adaa6e73e3997ae Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Wed, 19 Jun 2024 15:17:26 +0900 Subject: [PATCH] varlink-idl: allow unbalanced quote and trailing backslash in comment Fixes #33381. Fixes OSS-FUZZ#69730. Follow-up for fbb69c0306d434153ca85b227c7d42b9c92872e4. --- src/shared/varlink-idl.c | 2 +- test/fuzz/fuzz-varlink-idl/oss-fuzz-69730 | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 test/fuzz/fuzz-varlink-idl/oss-fuzz-69730 diff --git a/src/shared/varlink-idl.c b/src/shared/varlink-idl.c index 7e24ff7cc0d..78d719a4961 100644 --- a/src/shared/varlink-idl.c +++ b/src/shared/varlink-idl.c @@ -48,7 +48,7 @@ static int varlink_idl_format_comment( } _cleanup_strv_free_ char **l = NULL; - r = strv_split_full(&l, text, NEWLINE, 0); + r = strv_split_full(&l, text, NEWLINE, EXTRACT_RELAX); if (r < 0) return log_error_errno(r, "Failed to split comment string: %m"); diff --git a/test/fuzz/fuzz-varlink-idl/oss-fuzz-69730 b/test/fuzz/fuzz-varlink-idl/oss-fuzz-69730 new file mode 100644 index 00000000000..395638a794f --- /dev/null +++ b/test/fuzz/fuzz-varlink-idl/oss-fuzz-69730 @@ -0,0 +1,2 @@ +#\ +interface. \ No newline at end of file