system/systemd
system/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd synced 2024-09-06 08:46:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

basic/umask-util: drop clearing of unused bits in call to umask(2)

Browse source 
umask(2) says that the kernel does this exact operation on its own, so
we can drop if from our call.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2023-08-21 20:44:05 +02:00
parent e0cfdb85f5
commit 8980a53f24
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/basic/umask-util.h
View file

@ -8,12 +8,12 @@
#include "macro.h"
static inline void umaskp(mode_t *u) {
umask(*u & 0777);
umask(*u);
}
#define _cleanup_umask_ _cleanup_(umaskp)
/* We make use of the fact here that the umask() concept is using only the lower 9 bits of mode_t, although
/* We make use of the fact here that the umask() syscall uses only the lower 9 bits of mode_t, although
* mode_t has space for the file type in the bits further up. We simply OR in the file type mask S_IFMT to
* distinguish the first and the second iteration of the WITH_UMASK() loop, so that we can run the first one,
* and exit on the second. */