mirror of
https://github.com/systemd/systemd
synced 2024-10-07 00:30:59 +00:00
Fallback from pidfd_open on permission errors too
Skip using pidfds if we get a permission denied error. This can happen with an old policy and a new kernel that uses the new pidfs filesystem to back pidfds, instead of anonymous inodes, as the existing policy denies access. This is already the case for most uses of pidfd_open, like pidref, but not on these two. Fix them.
This commit is contained in:
parent
afdf63fcf2
commit
857945cc5f
|
@ -835,7 +835,7 @@ static int create_session_message(
|
|||
|
||||
if (!avoid_pidfd) {
|
||||
pidfd = pidfd_open(getpid_cached(), 0);
|
||||
if (pidfd < 0 && !ERRNO_IS_NOT_SUPPORTED(errno))
|
||||
if (pidfd < 0 && !ERRNO_IS_NOT_SUPPORTED(errno) && !ERRNO_IS_PRIVILEGE(errno))
|
||||
return -errno;
|
||||
}
|
||||
|
||||
|
|
|
@ -2261,7 +2261,7 @@ static int get_unit_dbus_path_by_pid(
|
|||
* sends the numeric PID. */
|
||||
|
||||
pidfd = pidfd_open(pid, 0);
|
||||
if (pidfd < 0 && ERRNO_IS_NOT_SUPPORTED(errno))
|
||||
if (pidfd < 0 && ERRNO_IS_NOT_SUPPORTED(errno) && !ERRNO_IS_PRIVILEGE(errno))
|
||||
return get_unit_dbus_path_by_pid_fallback(bus, pid, ret_path, ret_unit);
|
||||
if (pidfd < 0)
|
||||
return log_error_errno(errno, "Failed to open PID %"PRIu32": %m", pid);
|
||||
|
|
Loading…
Reference in a new issue