system/systemd
system/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd synced 2024-10-06 16:21:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

switch-root: sync() before MNT_DETACH unmounting all old mounts

Browse source 
As discussed here:

https://github.com/systemd/systemd/pull/27670#discussion_r1196716794
This commit is contained in:
Lennart Poettering 2023-05-19 14:22:14 +02:00
parent b7106af465
commit 5221b55bb3
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/shared/switch-root.c
View file

@ -63,6 +63,13 @@ int switch_root(const char *new_root,
(void) mkdir_p_label(resolved_old_root_after, 0755);
}
/* We are about to unmount various file systems with MNT_DETACH (either explicitly via umount() or
* indirectly via pivot_root()), and thus do not synchronously wait for them to be fully sync'ed —
* all while making them invisible/inaccessible in the file system tree for later code. That makes
* sync'ing them then difficult. Let's hence issue a manual sync() here, so that we at least can
* guarantee all file systems are an a good state before entering this state. */
sync();
/* Work-around for kernel design: the kernel refuses MS_MOVE if any file systems are mounted
* MS_SHARED. Hence remount them MS_PRIVATE here as a work-around.
*