system/systemd
system/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd synced 2024-07-21 18:24:38 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

doc: say in CODING_STYLE that AT_EMPTY_PATH should be implied on openat() style APIs (and NULL path is OK)

Browse source 
As discussed here:

https://github.com/systemd/systemd/pull/27397#issuecomment-1521630044
This commit is contained in:
Lennart Poettering 2023-04-25 13:56:20 +02:00 committed by Daan De Meyer
parent eb3641fc3c
commit 4d26b2277a
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
docs/CODING_STYLE.md
View file

@ -613,6 +613,15 @@ SPDX-License-Identifier: LGPL-2.1-or-later
effect on the regular file. If in doubt consider turning off `O_NONBLOCK`
again after opening.
- These days we generally prefer `openat()`-style file APIs, i.e. APIs that
accept a combination of file descriptor and path string, and where the path
(if not absolute) is considered relative to the specified file
descriptor. When implementing library calls in similar style, please make
sure to imply `AT_EMPTY_PATH` if an empty or `NULL` path argument is
specified (and convert that latter to an empty string). This differs from the
underlying kernel semantics, where `AT_EMPTY_PATH` must always be specified
explicitly, and `NULL` is not acepted as path.
## Command Line
- If you parse a command line, and want to store the parsed parameters in