From 3a768db480311d09365deb3286d6a7c546023208 Mon Sep 17 00:00:00 2001 From: Ronan Pigott Date: Thu, 11 Apr 2024 11:52:57 -0700 Subject: [PATCH] resolved: use NULL to represent an empty answer --- src/resolve/resolved-dns-transaction.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/resolve/resolved-dns-transaction.c b/src/resolve/resolved-dns-transaction.c index dc8b7c8ff0f..f6ce3e38db4 100644 --- a/src/resolve/resolved-dns-transaction.c +++ b/src/resolve/resolved-dns-transaction.c @@ -898,9 +898,7 @@ static int dns_transaction_dnssec_ready(DnsTransaction *t) { /* All good. */ break; - case DNS_TRANSACTION_DNSSEC_FAILED: { - DnsAnswer *empty; - + case DNS_TRANSACTION_DNSSEC_FAILED: /* We handle DNSSEC failures different from other errors, as we care about the DNSSEC * validation result */ @@ -921,14 +919,10 @@ static int dns_transaction_dnssec_ready(DnsTransaction *t) { /* The answer would normally be replaced by the validated subset, but at this point * we aren't going to bother validating the rest, so just drop it. */ - empty = dns_answer_new(0); - if (!empty) - return -ENOMEM; - DNS_ANSWER_REPLACE(t->answer, empty); + t->answer = dns_answer_unref(t->answer); dns_transaction_complete(t, DNS_TRANSACTION_DNSSEC_FAILED); return 0; - } default: log_debug("Auxiliary DNSSEC RR query failed with %s", dns_transaction_state_to_string(dt->state));