system/systemd
system/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd synced 2024-07-22 02:34:54 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

pwquality: fix use of ERRNO_IS_NOT_SUPPORTED

Browse source 
Given that ERRNO_IS_*() also match positive values, call
ERRNO_IS_NOT_SUPPORTED() only if the value returned by
pwq_allocate_context() is negative.
This commit is contained in:
Dmitry V. Levin 2023-07-05 08:00:00 +00:00
parent 5bc9ea070f
commit 29dd2e253c
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/shared/pwquality-util.c
View file

@ -107,10 +107,11 @@ int suggest_passwords(void) {
int r;
r = pwq_allocate_context(&pwq);
if (ERRNO_IS_NOT_SUPPORTED(r))
return 0;
if (r < 0)
if (r < 0) {
if (ERRNO_IS_NOT_SUPPORTED(r))
return 0;
return log_error_errno(r, "Failed to allocate libpwquality context: %m");
}
suggestions = new0(char*, N_SUGGESTIONS+1);
if (!suggestions)
@ -140,10 +141,11 @@ int quality_check_password(const char *password, const char *username, char **re
assert(password);
r = pwq_allocate_context(&pwq);
if (ERRNO_IS_NOT_SUPPORTED(r))
return 0;
if (r < 0)
if (r < 0) {
if (ERRNO_IS_NOT_SUPPORTED(r))
return 0;
return log_debug_errno(r, "Failed to allocate libpwquality context: %m");
}
r = sym_pwquality_check(pwq, password, NULL, username, &auxerror);
if (r < 0) {