system/systemd
system/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd synced 2024-10-02 22:37:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

hwdb: ASRock LED Controller classified incorrectly as joystick due to buttons and axis (#32775)

Browse source 
The function `builtin-input_id` incorrectly identifies the ASRock LED Controller
as an input device due to the presence of buttons and axis. To fix this we add
a new rule in `hwdb.d/60-input-id.hwdb`.
The properties have been set to empty instead of `0` because some programs
might check if the value is set at all instead of checking its value, as discussed
in #32773.

The device has no real keys. The devices is controlled by i2c interface and some
settings in UEFI, and it provides an header to connect LED strips and similar devices.
I suppose it's possible that ASRock intended to connect devices with buttons for
controlling LEDs to it, but: (i) the controller itself does not have key, (ii) to my
knowledge no such device exists. So I think we can unset that property as well.
On a sidenote, unsetting those properties does not affect the i2c interface,
OpenRGB still interacts normally with the device.

Fixes #32773.
This commit is contained in:
KayJay7 2024-05-13 15:49:07 +02:00 committed by GitHub
parent 034e85c5f3
commit 1642b7b3ac
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
hwdb.d/60-input-id.hwdb
View file

@ -79,3 +79,9 @@ id-input:modalias:input:b0003v068Ep00F2*
# TEX Shinobi Trackpoint
id-input:modalias:input:b0003v04D9p0407e0111-e0,1,2,4*
ID_INPUT_POINTINGSTICK=1
# ASRock LED Controller
id-input:modalias:input:b0003v26CEp01A2*
ID_INPUT_JOYSTICK=
ID_INPUT_KEY=
ID_INPUT=