mirror of
https://github.com/systemd/systemd
synced 2024-10-07 00:30:59 +00:00
zsh: update default caching policy for units
The existing caching policy was completely bogus. In the first stanza, despite the comment, the pattern given would consider the cache invalid if it was more than 1 hour old. The second stanza was also incorrect, since the output of `systemctl --all` is not unit file paths, but unit names. When they were being tested against the cachefile mtime, the test would always fail becuase of the nonexistant file (hopefully). In fact it's not very useful to test if the unit files have newer mtime in this case anyway, since we are only caching their names. Also, `systemctl --all` is an unfortunately slow operation to be used in testing for the cache validity — we want this operation to at least be faster than rebuilding the cache. I've rewritten this stanza with my best guess at its original intent. It now checks against the mtime of the parent directories in the search path, which should be updated and cause the cache to rebuild when we add, remove, or rename any unit files.
This commit is contained in:
parent
8a8caeccb2
commit
110ba0ccf9
|
@ -424,20 +424,13 @@ done
|
||||||
(( $+functions[_systemctl_caching_policy] )) ||
|
(( $+functions[_systemctl_caching_policy] )) ||
|
||||||
_systemctl_caching_policy()
|
_systemctl_caching_policy()
|
||||||
{
|
{
|
||||||
local _sysunits
|
|
||||||
local -a oldcache
|
|
||||||
|
|
||||||
# rebuild if cache is more than a day old
|
# rebuild if cache is more than a day old
|
||||||
oldcache=( "$1"(mh+1) )
|
[[ -n $1(#qNmd+1) ]] && return 0
|
||||||
(( $#oldcache )) && return 0
|
|
||||||
|
|
||||||
_sysunits=(${${(f)"$(__systemctl --all)"}%% *})
|
local pathkind=systemd-search-${1##*--}-unit
|
||||||
|
for dir in ${(s-:-)^$(_call_program $pathkind systemd-path $pathkind)}; do
|
||||||
if (( $#_sysunits )); then
|
[[ $dir -nt $1 ]] && return 0
|
||||||
for unit in $_sysunits; do
|
done
|
||||||
[[ "$unit" -nt "$1" ]] && return 0
|
|
||||||
done
|
|
||||||
fi
|
|
||||||
|
|
||||||
return 1
|
return 1
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue