system/systemd
system/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd synced 2024-09-30 05:15:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

copy: when a progress callback is provided, never copy more than 1M per iteration

Browse source 
Otherwise if we have to fill GB of data we might never call into the
callback, hence put some limit on how much to copy per iteration.
This commit is contained in:
Lennart Poettering 2024-05-24 12:17:00 +02:00
parent 22ed8700c7
commit 0de442ac31
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/shared/copy.c
View file

@ -41,8 +41,13 @@
#include "user-util.h"
#include "xattr-util.h"
/* If we copy via a userspace buffer, size it to 16K */
#define COPY_BUFFER_SIZE (16U*1024U)
/* If a byte progress function is specified during copying, never try to copy more than 1M, so that we can
* reasonably call the progress function still */
#define PROGRESS_STEP_SIZE (1U*U64_MB)
/* A safety net for descending recursively into file system trees to copy. On Linux PATH_MAX is 4096, which means the
* deepest valid path one can build is around 2048, which we hence use as a safety net here, to not spin endlessly in
* case of bind mount cycles and suchlike. */
@ -284,6 +289,9 @@ int copy_bytes_full(
if (max_bytes != UINT64_MAX && m > max_bytes)
m = max_bytes;
if (progress && m > PROGRESS_STEP_SIZE)
m = PROGRESS_STEP_SIZE;
if (copy_flags & COPY_HOLES) {
off_t c, e;