systemd/coccinelle/safe_close.cocci

/* SPDX-License-Identifier: LGPL-2.1-or-later */
@@
expression fd;
@@
- close(fd);
- fd = -EBADF;
+ fd = safe_close(fd);
@@
expression fd;
@@
- close_nointr(fd);
- fd = -EBADF;
+ fd = safe_close(fd);
@@
expression fd;
@@
- safe_close(fd);
- fd = -EBADF;
+ fd = safe_close(fd);
licensing: add spdx to our .cocci files Since those are chunks of code based on our codebase, it's easiest to use the same license. 2021-10-01 10:28:36 +00:00			`/* SPDX-License-Identifier: LGPL-2.1-or-later */`
tree-wide: make more code use safe_close() Replace this: close(fd); fd = -1; write this: fd = safe_close(fd); 2015-09-08 16:53:19 +00:00			`@@`
			`expression fd;`
			`@@`
			`- close(fd);`
tree-wide: use -EBADF for fd initialization -1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary. 2022-12-19 12:07:42 +00:00			`- fd = -EBADF;`
tree-wide: make more code use safe_close() Replace this: close(fd); fd = -1; write this: fd = safe_close(fd); 2015-09-08 16:53:19 +00:00			`+ fd = safe_close(fd);`
			`@@`
			`expression fd;`
			`@@`
			`- close_nointr(fd);`
tree-wide: use -EBADF for fd initialization -1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary. 2022-12-19 12:07:42 +00:00			`- fd = -EBADF;`
tree-wide: make more code use safe_close() Replace this: close(fd); fd = -1; write this: fd = safe_close(fd); 2015-09-08 16:53:19 +00:00			`+ fd = safe_close(fd);`
			`@@`
			`expression fd;`
			`@@`
			`- safe_close(fd);`
tree-wide: use -EBADF for fd initialization -1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary. 2022-12-19 12:07:42 +00:00			`- fd = -EBADF;`
tree-wide: make more code use safe_close() Replace this: close(fd); fd = -1; write this: fd = safe_close(fd); 2015-09-08 16:53:19 +00:00			`+ fd = safe_close(fd);`