1
0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-09 11:20:46 +00:00
Go to file
Matthew Olsson 76fa127cbf LibJSGCVerifier: Detect stack-allocated ref captures in lambdas
For example, consider the following code snippet:

    Vector<Function<void()>> m_callbacks;
    void add_callback(Function<void()> callback)
    {
    	m_callbacks.append(move(callback));
    }

    // Somewhere else...
    void do_something()
    {
    	int a = 10;
    	add_callback([&a] {
            dbgln("a is {}", a);
    	});
    } // Oops, "a" is now destroyed, but the callback in m_callbacks
      // has a reference to it!

We now statically detect the capture of "a" in the lambda above and flag
it as incorrect. Note that capturing the value implicitly with a capture
list of `[&]` would also be detected.

Of course, many functions that accept Function<...> don't store them
anywhere, instead immediately invoking them inside of the function. To
avoid a warning in this case, the parameter can be annotated with
NOESCAPE to indicate that capturing stack variables is fine:

    void do_something_now(NOESCAPE Function<...> callback)
    {
    	callback(...)
    }

Lastly, there are situations where the callback does generally escape,
but where the caller knows that it won't escape long enough to cause any
issues. For example, consider this fake example from LibWeb:

    void do_something()
    {
    	bool is_done = false;
    	HTML::queue_global_task([&] {
            do_some_work();
            is_done = true;
        });
    	HTML::main_thread_event_loop().spin_until([&] {
            return is_done;
        });
    }

In this case, we know that the lambda passed to queue_global_task will
be executed before the function returns, and will not persist
afterwards. To avoid this warning, annotate the type of the capture
with IGNORE_USE_IN_ESCAPING_LAMBDA:

    void do_something()
    {
   	IGNORE_USE_IN_ESCAPING_LAMBDA bool is_done = false;
    	// ...
    }
2024-04-09 09:10:44 +02:00
.devcontainer Meta: Switch to clang-format-16 as the standard formatter 2023-07-08 10:32:56 +01:00
.github Meta: Add Polar to FUNDING.yml 2024-02-21 07:36:55 +01:00
AK LibJSGCVerifier: Detect stack-allocated ref captures in lambdas 2024-04-09 09:10:44 +02:00
Base LibWeb: Add support for select options disabled state 2024-04-08 17:24:48 -04:00
Documentation Documentation: Add more specific instructions on how to use the GN build 2024-04-08 18:49:41 -06:00
Kernel Kernel/riscv64: Add Linux boot header 2024-03-25 14:30:39 -06:00
Ladybird Ladybird: Add indentation to options in optgroup in select dropdown 2024-04-08 17:24:48 -04:00
Meta LibJSGCVerifier: Detect stack-allocated ref captures in lambdas 2024-04-09 09:10:44 +02:00
Ports Ports: Enable more poppler features 2024-04-07 16:35:22 +02:00
Tests LibWeb: Refactor SelectItem to allow selecting options without value 2024-04-08 17:24:48 -04:00
Toolchain nix: Clean up files, use good practices 2024-03-25 14:19:34 -06:00
Userland Ladybird: Add indentation to options in optgroup in select dropdown 2024-04-08 17:24:48 -04:00
.clang-format Meta: Support using clang-format on Objective-C++ files 2023-08-22 21:36:19 -04:00
.clang-tidy Meta: Disable readability-function-cognitive-complexity in clang-tidy 2024-02-05 08:04:24 -07:00
.editorconfig Meta: Add .editorconfig 2022-09-10 17:32:55 +01:00
.gitattributes
.gitignore Meta: Move .DS_Store rule to the bottom of the .gitignore file 2023-11-14 14:53:37 -05:00
.gn Meta: Automatically generate a compilation database for clangd 2023-11-14 14:29:35 -05:00
.mailmap Everywhere: Update copyrights with my new serenityos.org e-mail :^) 2023-07-15 16:21:29 +02:00
.pre-commit-config.yaml
.prettierignore LibJS: Add DisposableStack{, Prototype, Constructor} 2023-01-23 09:56:50 +00:00
.prettierrc
.ycm_extra_conf.py Meta: Remove i686 references in YCM configuration 2022-12-28 11:53:41 +01:00
azure-pipelines.yml CI: Remove extraneous toolchain job from Azure CI 2022-12-28 15:26:12 -05:00
CMakeLists.txt Meta: Replace run.sh by run.py 2023-12-15 00:11:50 +01:00
CONTRIBUTING.md Meta: Add a note about resolving PR review comments 2023-10-18 13:32:13 +02:00
flake.lock nix: Clean up files, use good practices 2024-03-25 14:19:34 -06:00
flake.nix nix: Clean up files, use good practices 2024-03-25 14:19:34 -06:00
LICENSE Meta: Update the year range in LICENSE 2024-01-06 17:39:16 -05:00
README.md Meta: Add implicitfield to the contributors list :^) 2024-02-26 13:51:40 -07:00
SECURITY.md Meta: Add a security policy 2022-06-29 03:29:27 +00:00

SerenityOS

Graphical Unix-like operating system for x86-64 computers.

GitHub Actions Status Azure DevOps Status Fuzzing Status Sonar Cube Static Analysis Discord

FAQ | Documentation | Build Instructions

About

SerenityOS is a love letter to '90s user interfaces with a custom Unix-like core. It flatters with sincerity by stealing beautiful ideas from various other systems.

Roughly speaking, the goal is a marriage between the aesthetic of late-1990s productivity software and the power-user accessibility of late-2000s *nix. This is a system by us, for us, based on the things we like.

You can watch videos of the system being developed on YouTube:

Screenshot

Screenshot as of c03b788.png

Features

  • Modern x86 64-bit kernel with pre-emptive multi-threading
  • Browser with JavaScript, WebAssembly, and more (check the spec compliance for JS, CSS, and Wasm)
  • Security features (hardware protections, limited userland capabilities, W^X memory, pledge & unveil, (K)ASLR, OOM-resistance, web-content isolation, state-of-the-art TLS algorithms, ...)
  • System services (WindowServer, LoginServer, AudioServer, WebServer, RequestServer, CrashServer, ...) and modern IPC
  • Good POSIX compatibility (LibC, Shell, syscalls, signals, pseudoterminals, filesystem notifications, standard Unix utilities, ...)
  • POSIX-like virtual file systems (/proc, /dev, /sys, /tmp, ...) and ext2 file system
  • Network stack and applications with support for IPv4, TCP, UDP; DNS, HTTP, Gemini, IMAP, NTP
  • Profiling, debugging and other development tools (Kernel-supported profiling, CrashReporter, interactive GUI playground, HexEditor, HackStudio IDE for C++ and more)
  • Libraries for everything from cryptography to OpenGL, audio, JavaScript, GUI, playing chess, ...
  • Support for many common and uncommon file formats (PNG, JPEG, GIF, MP3, WAV, FLAC, ZIP, TAR, PDF, QOI, Gemini, ...)
  • Unified style and design philosophy, flexible theming system, custom (bitmap and vector) fonts
  • Games (Solitaire, Minesweeper, 2048, chess, Conway's Game of Life, ...) and demos (CatDog, Starfield, Eyes, mandelbrot set, WidgetGallery, ...)
  • Every-day GUI programs and utilities (Spreadsheet with JavaScript, TextEditor, Terminal, PixelPaint, various multimedia viewers and players, Mail, Assistant, Calculator, ...)

... and all of the above are right in this repository, no extra dependencies, built from-scratch by us :^)

Additionally, there are over three hundred ports of popular open-source software, including games, compilers, Unix tools, multimedia apps and more.

How do I read the documentation?

Man pages are available online at man.serenityos.org. These pages are generated from the Markdown source files in Base/usr/share/man and updated automatically.

When running SerenityOS you can use man for the terminal interface, or help for the GUI.

Code-related documentation can be found in the documentation folder.

How do I build and run this?

See the SerenityOS build instructions. Serenity runs on Linux, macOS (aarch64 might be a challenge), Windows (with WSL2) and many other *Nixes with hardware or software virtualization.

Get in touch and participate!

Join our Discord server: SerenityOS Discord

Before opening an issue, please see the issue policy.

A general guide for contributing can be found in CONTRIBUTING.md.

Authors

And many more! See here for a full contributor list. The people listed above have landed more than 100 commits in the project. :^)

License

SerenityOS is licensed under a 2-clause BSD license.