mirror of
https://github.com/SerenityOS/serenity
synced 2024-07-23 11:04:40 +00:00
ab06a76920
MasterPTY's double buffer unblock callback would take m_slave's spinlock and then call evaluate_block_conditions() which would take BlockerSet's spinlock, while on the other hand, BlockerSet's add_blocker would take BlockerSet's spinlock, and then call should_add_blocker, which would call unblock_if_conditions_are_met, which would then call should_unblock, which will finally call MasterPTY::can_read() which will take m_slave's spinlock. Resolve this by moving the call to evaluate_block_conditions() out of the scope of m_slave's spinlock, as there's no need to hold the lock while calling it anyways.
58 lines
1.9 KiB
C++
58 lines
1.9 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/Badge.h>
|
|
#include <Kernel/Devices/CharacterDevice.h>
|
|
#include <Kernel/Library/DoubleBuffer.h>
|
|
|
|
namespace Kernel {
|
|
|
|
class SlavePTY;
|
|
|
|
class MasterPTY final : public CharacterDevice {
|
|
public:
|
|
static ErrorOr<NonnullRefPtr<MasterPTY>> try_create(unsigned index);
|
|
virtual ~MasterPTY() override;
|
|
|
|
unsigned index() const { return m_index; }
|
|
ErrorOr<size_t> on_slave_write(UserOrKernelBuffer const&, size_t);
|
|
bool can_write_from_slave() const;
|
|
void notify_slave_closed(Badge<SlavePTY>);
|
|
bool is_closed() const { return m_closed; }
|
|
|
|
virtual ErrorOr<NonnullOwnPtr<KString>> pseudo_path(OpenFileDescription const&) const override;
|
|
|
|
private:
|
|
explicit MasterPTY(unsigned index, NonnullOwnPtr<DoubleBuffer> buffer);
|
|
|
|
// ^Device
|
|
virtual bool is_openable_by_jailed_processes() const override { return true; }
|
|
|
|
// ^CharacterDevice
|
|
virtual ErrorOr<size_t> read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override;
|
|
virtual ErrorOr<size_t> write(OpenFileDescription&, u64, UserOrKernelBuffer const&, size_t) override;
|
|
virtual bool can_read(OpenFileDescription const&, u64) const override;
|
|
virtual bool can_write(OpenFileDescription const&, u64) const override;
|
|
virtual ErrorOr<void> close() override;
|
|
virtual bool is_master_pty() const override { return true; }
|
|
virtual ErrorOr<void> ioctl(OpenFileDescription&, unsigned request, Userspace<void*> arg) override;
|
|
virtual StringView class_name() const override { return "MasterPTY"sv; }
|
|
|
|
bool has_slave() const
|
|
{
|
|
return m_slave.with([](auto& slave) -> bool { return slave; });
|
|
}
|
|
|
|
SpinlockProtected<RefPtr<SlavePTY>, LockRank::None> m_slave;
|
|
unsigned m_index;
|
|
bool m_closed { false };
|
|
NonnullOwnPtr<DoubleBuffer> m_buffer;
|
|
};
|
|
|
|
}
|