1
0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-09 07:40:45 +00:00
serenity/Tests/AK/TestNeverDestroyed.cpp
Daniel Bertalan 6c4e0e8549 Tests: Stop invoking UB in AK::NeverDestroyed's tests
Instead of attempting a stack use-after-free by reading an out-of-scope
object's data member, let's keep a flag that checks if the destructor
had been called in the outer scope.
2024-06-06 13:01:12 +02:00

87 lines
1.5 KiB
C++

/*
* Copyright (c) 2020, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibTest/TestCase.h>
#include <AK/NeverDestroyed.h>
#include <AK/StdLibExtras.h>
struct Counter {
Counter() = default;
~Counter() { ++num_destroys; }
Counter(Counter const&)
{
++num_copies;
}
Counter(Counter&&) { ++num_moves; }
int num_copies {};
int num_moves {};
int num_destroys {};
};
TEST_CASE(should_construct_by_copy)
{
Counter c {};
AK::NeverDestroyed<Counter> n { c };
EXPECT_EQ(1, n->num_copies);
EXPECT_EQ(0, n->num_moves);
}
TEST_CASE(should_construct_by_move)
{
Counter c {};
AK::NeverDestroyed<Counter> n { move(c) };
EXPECT_EQ(0, n->num_copies);
EXPECT_EQ(1, n->num_moves);
}
struct DestructorChecker {
DestructorChecker(bool& destroyed)
: m_destroyed(destroyed)
{
}
~DestructorChecker()
{
m_destroyed = true;
}
bool& m_destroyed;
};
TEST_CASE(should_not_destroy)
{
bool destroyed = false;
{
AK::NeverDestroyed<DestructorChecker> n(destroyed);
}
EXPECT(!destroyed);
}
TEST_CASE(should_provide_dereference_operator)
{
AK::NeverDestroyed<Counter> n {};
EXPECT_EQ(0, n->num_destroys);
}
TEST_CASE(should_provide_indirection_operator)
{
AK::NeverDestroyed<Counter> n {};
EXPECT_EQ(0, (*n).num_destroys);
}
TEST_CASE(should_provide_basic_getter)
{
AK::NeverDestroyed<Counter> n {};
EXPECT_EQ(0, n.get().num_destroys);
}