mirror of
https://github.com/SerenityOS/serenity
synced 2024-09-19 16:01:40 +00:00
3f3f45580a
Each of these strings would previously rely on StringView's char const* constructor overload, which would call __builtin_strlen on the string. Since we now have operator ""sv, we can replace these with much simpler versions. This opens the door to being able to remove StringView(char const*). No functional changes.
32 lines
1.4 KiB
C++
32 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2022, Luke Wilde <lukew@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibTest/TestCase.h>
|
|
#include <LibXML/Parser/Parser.h>
|
|
|
|
TEST_CASE(char_data_ending)
|
|
{
|
|
EXPECT_NO_CRASH("parsing character data ending by itself should not crash", [] {
|
|
// After seeing `<C>`, the parser will start parsing the content of the element. The content parser will then parse any character data it sees.
|
|
// The character parser would see the first two `]]` and consume them. Then, it would see the `>` and set the state machine to say we have seen this,
|
|
// but it did _not_ consume it and would instead tell GenericLexer that it should stop consuming characters. Therefore, we only consumed 2 characters.
|
|
// Then, it would see that we are in the state where we've seen the full `]]>` and try to take off three characters from the end of the consumed
|
|
// input when we only have 2 characters, causing an assertion failure as we are asking to take off more characters than there really is.
|
|
XML::Parser parser("<C>]]>"sv);
|
|
(void)parser.parse();
|
|
return Test::Crash::Failure::DidNotCrash;
|
|
});
|
|
}
|
|
|
|
TEST_CASE(character_reference_integer_overflow)
|
|
{
|
|
EXPECT_NO_CRASH("parsing character references that do not fit in 32 bits should not crash", [] {
|
|
XML::Parser parser("<G>�"sv);
|
|
(void)parser.parse();
|
|
return Test::Crash::Failure::DidNotCrash;
|
|
});
|
|
}
|